From 1c77fcd712e0bfeb1cc4719577513136d12995f3 Mon Sep 17 00:00:00 2001 From: Marco Bonardo Date: Fri, 5 Dec 2008 16:28:22 +0100 Subject: [PATCH] Bug 441470 - Bookmark lost when dragged within folder shortcuts menus, r=dietrich --- browser/components/places/content/menu.xml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/browser/components/places/content/menu.xml b/browser/components/places/content/menu.xml index 81e44d6dd39..5cfbff56186 100755 --- a/browser/components/places/content/menu.xml +++ b/browser/components/places/content/menu.xml @@ -290,9 +290,10 @@ if (!xulNode.node) { // if we are dragging over a non places node drop at the end - dropPoint.ip = new InsertionPoint(resultNode.itemId, - -1, - Ci.nsITreeView.DROP_ON); + dropPoint.ip = new InsertionPoint( + PlacesUtils.getConcreteItemId(resultNode), + -1, + Ci.nsITreeView.DROP_ON); return dropPoint; } else if ((PlacesUtils.nodeIsFolder(xulNode.node) || @@ -303,7 +304,7 @@ // If the mouse is in the top 25% of the node, // drop above the folder. dropPoint.ip = new InsertionPoint( - resultNode.itemId, + PlacesUtils.getConcreteItemId(resultNode), -1, Ci.nsITreeView.DROP_BEFORE, PlacesUtils.nodeIsTagQuery(xulNode.node), @@ -326,7 +327,7 @@ // This is a non-folder node or a readonly folder. // If the mouse is above the middle, drop above this item. dropPoint.ip = new InsertionPoint( - resultNode.itemId, + PlacesUtils.getConcreteItemId(resultNode), -1, Ci.nsITreeView.DROP_BEFORE, PlacesUtils.nodeIsTagQuery(xulNode.node), @@ -336,7 +337,7 @@ // Drop below the item. dropPoint.ip = new InsertionPoint( - resultNode.itemId, + PlacesUtils.getConcreteItemId(resultNode), -1, Ci.nsITreeView.DROP_AFTER, PlacesUtils.nodeIsTagQuery(xulNode.node),