Bug 851378 - Avoid bogus assertion when trying to spawn disabled plugin. r=bsmedberg

This commit is contained in:
John Schoenick 2013-03-19 15:38:58 -07:00
parent aa811f364c
commit 1c38d16428

View File

@ -1049,7 +1049,14 @@ nsPluginHost::TrySetUpPluginInstance(const char *aMimeType,
PR_LogFlush();
#endif
nsRefPtr<nsNPAPIPlugin> plugin;
GetPlugin(aMimeType, getter_AddRefs(plugin));
if (!plugin) {
return NS_ERROR_FAILURE;
}
nsPluginTag* pluginTag = FindPluginForType(aMimeType, true);
NS_ASSERTION(pluginTag, "Must have plugin tag here!");
#if defined(MOZ_WIDGET_ANDROID) && defined(MOZ_CRASHREPORTER)
@ -1058,12 +1065,6 @@ nsPluginHost::TrySetUpPluginInstance(const char *aMimeType,
}
#endif
nsRefPtr<nsNPAPIPlugin> plugin;
GetPlugin(aMimeType, getter_AddRefs(plugin));
if (!plugin) {
return NS_ERROR_FAILURE;
}
nsRefPtr<nsNPAPIPluginInstance> instance = new nsNPAPIPluginInstance();
// This will create the owning reference. The connection must be made between the