From 91c7eecd90d2ec314880fb8e056f9376bc0edc73 Mon Sep 17 00:00:00 2001 From: Lucas Rocha Date: Wed, 2 Oct 2013 15:46:13 +0100 Subject: [PATCH 01/16] Bug 919516 - No need to account for header views in Bookmarks page (r=mfinkle) --- mobile/android/base/home/BookmarksListView.java | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/mobile/android/base/home/BookmarksListView.java b/mobile/android/base/home/BookmarksListView.java index 14918cdacb7..f60d20c15fe 100644 --- a/mobile/android/base/home/BookmarksListView.java +++ b/mobile/android/base/home/BookmarksListView.java @@ -62,17 +62,6 @@ public class BookmarksListView extends HomeListView @Override public void onItemClick(AdapterView parent, View view, int position, long id) { - final ListView list = (ListView) parent; - final int headerCount = list.getHeaderViewsCount(); - - if (position < headerCount) { - // The click is on a header, don't do anything. - return; - } - - // Absolute position for the adapter. - position -= headerCount; - final BookmarksListAdapter adapter = getBookmarksListAdapter(); if (adapter.isShowingChildFolder()) { if (position == 0) { From 6425aad4c21a9b6ce8ef28d557430790ede8ff5a Mon Sep 17 00:00:00 2001 From: Chris Kitching Date: Wed, 2 Oct 2013 11:31:37 -0400 Subject: [PATCH 02/16] Bug 922116 - Don't clear FaviconView image data in formatImage. r=lucasr,margaret --- mobile/android/base/widget/FaviconView.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mobile/android/base/widget/FaviconView.java b/mobile/android/base/widget/FaviconView.java index 87e78cbe045..a8ce697f999 100644 --- a/mobile/android/base/widget/FaviconView.java +++ b/mobile/android/base/widget/FaviconView.java @@ -64,7 +64,7 @@ public class FaviconView extends ImageView { private void formatImage() { // If we're called before bitmap is set, or before size is set, show blank. if (mIconBitmap == null || mActualWidth == 0 || mActualHeight == 0) { - clearImage(); + showNoImage(); return; } @@ -157,12 +157,16 @@ public class FaviconView extends ImageView { hideBackground(); } + private void showNoImage() { + setImageBitmap(null); + hideBackground(); + } + /** * Clear image and background shown by this view. */ public void clearImage() { - setImageResource(0); - hideBackground(); + showNoImage(); mUnscaledBitmap = null; mIconBitmap = null; mIconKey = null; From c08f93f7fed42fcdbf70e0a72f505da48f130ac0 Mon Sep 17 00:00:00 2001 From: Lucas Rocha Date: Wed, 2 Oct 2013 17:32:42 +0100 Subject: [PATCH 03/16] Bug 911695 - Use correct dppx values for HDPI and XHDPI devices (r=margaret) --- mobile/android/themes/core/aboutReader.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mobile/android/themes/core/aboutReader.css b/mobile/android/themes/core/aboutReader.css index 540d24918ae..0b95b8598a1 100644 --- a/mobile/android/themes/core/aboutReader.css +++ b/mobile/android/themes/core/aboutReader.css @@ -519,7 +519,7 @@ body { background-image: url('chrome://browser/skin/images/reader-style-icon-mdpi.png'); } -@media screen and (min-resolution: 200dpi) { +@media screen and (min-resolution: 1.25dppx) { .dropdown-arrow { background-image: url('chrome://browser/skin/images/reader-dropdown-arrow-hdpi.png'); } @@ -557,7 +557,7 @@ body { } } -@media screen and (min-resolution: 300dpi) { +@media screen and (min-resolution: 2dppx) { .dropdown-arrow { background-image: url('chrome://browser/skin/images/reader-dropdown-arrow-xhdpi.png'); } From 13aba9ae7705e63e36dcdebe3e0edbef197a06cf Mon Sep 17 00:00:00 2001 From: Wes Johnston Date: Wed, 2 Oct 2013 11:18:16 -0700 Subject: [PATCH 04/16] Bug 920170 - Move Android prompt service components to their own namespace. r=margaret --HG-- rename : mobile/android/base/Prompt.java => mobile/android/base/prompts/Prompt.java rename : mobile/android/base/PromptInput.java => mobile/android/base/prompts/PromptInput.java rename : mobile/android/base/PromptService.java => mobile/android/base/prompts/PromptService.java --- mobile/android/base/ActivityHandlerHelper.java | 2 ++ mobile/android/base/BaseGeckoInterface.java | 1 + mobile/android/base/BrowserApp.java | 1 + mobile/android/base/DoorHanger.java | 1 + mobile/android/base/DoorHangerPopup.java | 1 + mobile/android/base/GeckoApp.java | 1 + mobile/android/base/GeckoAppShell.java | 1 + mobile/android/base/Makefile.in | 6 +++--- mobile/android/base/{ => prompts}/Prompt.java | 5 ++++- mobile/android/base/{ => prompts}/PromptInput.java | 5 +++-- mobile/android/base/{ => prompts}/PromptService.java | 6 ++++-- 11 files changed, 22 insertions(+), 8 deletions(-) rename mobile/android/base/{ => prompts}/Prompt.java (99%) rename mobile/android/base/{ => prompts}/PromptInput.java (99%) rename mobile/android/base/{ => prompts}/PromptService.java (95%) diff --git a/mobile/android/base/ActivityHandlerHelper.java b/mobile/android/base/ActivityHandlerHelper.java index 53a5fecd34e..90404d043b0 100644 --- a/mobile/android/base/ActivityHandlerHelper.java +++ b/mobile/android/base/ActivityHandlerHelper.java @@ -4,6 +4,8 @@ package org.mozilla.gecko; +import org.mozilla.gecko.prompts.Prompt; +import org.mozilla.gecko.prompts.PromptService; import org.mozilla.gecko.util.ActivityResultHandler; import org.mozilla.gecko.util.ActivityResultHandlerMap; import org.mozilla.gecko.util.ThreadUtils; diff --git a/mobile/android/base/BaseGeckoInterface.java b/mobile/android/base/BaseGeckoInterface.java index db36fe4a8e6..23a49506abd 100644 --- a/mobile/android/base/BaseGeckoInterface.java +++ b/mobile/android/base/BaseGeckoInterface.java @@ -7,6 +7,7 @@ package org.mozilla.gecko; import org.mozilla.gecko.util.HardwareUtils; import org.mozilla.gecko.util.ThreadUtils; +import org.mozilla.gecko.prompts.PromptService; import android.app.Activity; import android.content.Context; diff --git a/mobile/android/base/BrowserApp.java b/mobile/android/base/BrowserApp.java index 3595a629014..d199b349b78 100644 --- a/mobile/android/base/BrowserApp.java +++ b/mobile/android/base/BrowserApp.java @@ -20,6 +20,7 @@ import org.mozilla.gecko.home.BrowserSearch; import org.mozilla.gecko.home.HomePager; import org.mozilla.gecko.home.HomePager.OnUrlOpenListener; import org.mozilla.gecko.menu.GeckoMenu; +import org.mozilla.gecko.prompts.Prompt; import org.mozilla.gecko.util.Clipboard; import org.mozilla.gecko.util.GamepadUtils; import org.mozilla.gecko.util.HardwareUtils; diff --git a/mobile/android/base/DoorHanger.java b/mobile/android/base/DoorHanger.java index 4c2fa43b155..7e7b76b54ad 100644 --- a/mobile/android/base/DoorHanger.java +++ b/mobile/android/base/DoorHanger.java @@ -6,6 +6,7 @@ package org.mozilla.gecko; import org.mozilla.gecko.widget.Divider; +import org.mozilla.gecko.prompts.PromptInput; import org.json.JSONArray; import org.json.JSONException; diff --git a/mobile/android/base/DoorHangerPopup.java b/mobile/android/base/DoorHangerPopup.java index 6600260b308..7d29e8f4aee 100644 --- a/mobile/android/base/DoorHangerPopup.java +++ b/mobile/android/base/DoorHangerPopup.java @@ -7,6 +7,7 @@ package org.mozilla.gecko; import org.mozilla.gecko.util.GeckoEventListener; import org.mozilla.gecko.widget.ArrowPopup; +import org.mozilla.gecko.prompts.PromptInput; import org.json.JSONArray; import org.json.JSONException; diff --git a/mobile/android/base/GeckoApp.java b/mobile/android/base/GeckoApp.java index 5400efcb672..d1ddb8e524c 100644 --- a/mobile/android/base/GeckoApp.java +++ b/mobile/android/base/GeckoApp.java @@ -12,6 +12,7 @@ import org.mozilla.gecko.gfx.BitmapUtils; import org.mozilla.gecko.gfx.Layer; import org.mozilla.gecko.gfx.LayerView; import org.mozilla.gecko.gfx.PluginLayer; +import org.mozilla.gecko.prompts.PromptService; import org.mozilla.gecko.menu.GeckoMenu; import org.mozilla.gecko.menu.GeckoMenuInflater; import org.mozilla.gecko.menu.MenuPanel; diff --git a/mobile/android/base/GeckoAppShell.java b/mobile/android/base/GeckoAppShell.java index 779b9a593aa..28d91f00cff 100644 --- a/mobile/android/base/GeckoAppShell.java +++ b/mobile/android/base/GeckoAppShell.java @@ -10,6 +10,7 @@ import org.mozilla.gecko.gfx.GeckoLayerClient; import org.mozilla.gecko.gfx.GfxInfoThread; import org.mozilla.gecko.gfx.LayerView; import org.mozilla.gecko.gfx.PanZoomController; +import org.mozilla.gecko.prompts.PromptService; import org.mozilla.gecko.mozglue.GeckoLoader; import org.mozilla.gecko.mozglue.GeneratableAndroidBridgeTarget; import org.mozilla.gecko.mozglue.OptionalGeneratedParameter; diff --git a/mobile/android/base/Makefile.in b/mobile/android/base/Makefile.in index 8aca011f78d..7bf726792d3 100644 --- a/mobile/android/base/Makefile.in +++ b/mobile/android/base/Makefile.in @@ -126,9 +126,9 @@ FENNEC_JAVA_FILES = \ PrefsHelper.java \ PrivateDataPreference.java \ PrivateTab.java \ - Prompt.java \ - PromptInput.java \ - PromptService.java \ + prompts/Prompt.java \ + prompts/PromptInput.java \ + prompts/PromptService.java \ Restarter.java \ sqlite/ByteBufferInputStream.java \ sqlite/MatrixBlobCursor.java \ diff --git a/mobile/android/base/Prompt.java b/mobile/android/base/prompts/Prompt.java similarity index 99% rename from mobile/android/base/Prompt.java rename to mobile/android/base/prompts/Prompt.java index 5a29ec553f6..210dc4ce2c2 100644 --- a/mobile/android/base/Prompt.java +++ b/mobile/android/base/prompts/Prompt.java @@ -3,11 +3,14 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -package org.mozilla.gecko; +package org.mozilla.gecko.prompts; import org.mozilla.gecko.util.GeckoEventResponder; +import org.mozilla.gecko.GeckoEvent; import org.mozilla.gecko.util.ThreadUtils; import org.mozilla.gecko.widget.DateTimePicker; +import org.mozilla.gecko.R; +import org.mozilla.gecko.GeckoAppShell; import org.json.JSONArray; import org.json.JSONObject; diff --git a/mobile/android/base/PromptInput.java b/mobile/android/base/prompts/PromptInput.java similarity index 99% rename from mobile/android/base/PromptInput.java rename to mobile/android/base/prompts/PromptInput.java index 80d9b4ac306..47c39dd4d55 100644 --- a/mobile/android/base/PromptInput.java +++ b/mobile/android/base/prompts/PromptInput.java @@ -3,8 +3,9 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -package org.mozilla.gecko; +package org.mozilla.gecko.prompts; +import org.mozilla.gecko.AllCapsTextView; import org.mozilla.gecko.util.GeckoEventResponder; import org.mozilla.gecko.util.ThreadUtils; import org.mozilla.gecko.widget.DateTimePicker; @@ -40,7 +41,7 @@ import java.util.GregorianCalendar; import java.util.concurrent.ConcurrentLinkedQueue; import java.util.concurrent.TimeUnit; -class PromptInput { +public class PromptInput { private final JSONObject mJSONInput; protected final String mLabel; diff --git a/mobile/android/base/PromptService.java b/mobile/android/base/prompts/PromptService.java similarity index 95% rename from mobile/android/base/PromptService.java rename to mobile/android/base/prompts/PromptService.java index 178f17c27d2..3682832990a 100644 --- a/mobile/android/base/PromptService.java +++ b/mobile/android/base/prompts/PromptService.java @@ -3,8 +3,10 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -package org.mozilla.gecko; +package org.mozilla.gecko.prompts; +import org.mozilla.gecko.GeckoAppShell; +import org.mozilla.gecko.GeckoEvent; import org.mozilla.gecko.util.GeckoEventResponder; import org.mozilla.gecko.util.ThreadUtils; @@ -27,7 +29,7 @@ public class PromptService implements GeckoEventResponder { mContext = context; } - void destroy() { + public void destroy() { GeckoAppShell.getEventDispatcher().unregisterEventListener("Prompt:Show", this); GeckoAppShell.getEventDispatcher().unregisterEventListener("Prompt:ShowTop", this); } From f74dad9d18b93a7ee06e79326e2ad6cae263e872 Mon Sep 17 00:00:00 2001 From: Gijs Kruitbosch Date: Wed, 2 Oct 2013 19:53:25 +0200 Subject: [PATCH 05/16] Bug 923186 - Download button should use regular XBL. r=mconley --- browser/base/content/browser.xul | 10 +--------- browser/components/downloads/content/download.xml | 3 +++ 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/browser/base/content/browser.xul b/browser/base/content/browser.xul index f6d88e4fcb1..fef810d8b89 100644 --- a/browser/base/content/browser.xul +++ b/browser/base/content/browser.xul @@ -912,16 +912,8 @@ ondrop="DownloadsIndicatorView.onDrop(event);" ondragover="DownloadsIndicatorView.onDragOver(event);" ondragenter="DownloadsIndicatorView.onDragOver(event);" - xmlns:xbl="http://www.mozilla.org/xbl" label="&downloads.label;" - tooltiptext="&downloads.tooltip;"> - - -