Bug 478570. SVG feConvolveMatrix 'order' attribute should default to 3, as per spec errata. r=roc,longsonr

--HG--
extra : rebase_source : 68e462f74e11f108735586bfde1441ad0b3760c3
This commit is contained in:
Martin 2009-02-17 09:59:06 +00:00
parent 6582a15604
commit 1ae1dfd23b
4 changed files with 33 additions and 2 deletions

View File

@ -3812,8 +3812,8 @@ nsSVGElement::NumberInfo nsSVGFEConvolveMatrixElement::sNumberInfo[4] =
nsSVGElement::IntegerInfo nsSVGFEConvolveMatrixElement::sIntegerInfo[4] =
{
{ &nsGkAtoms::order, 0 },
{ &nsGkAtoms::order, 0 },
{ &nsGkAtoms::order, 3 },
{ &nsGkAtoms::order, 3 },
{ &nsGkAtoms::targetX, 0 },
{ &nsGkAtoms::targetY, 0 }
};

View File

@ -0,0 +1,12 @@
<svg xmlns="http://www.w3.org/2000/svg">
<defs>
<filter id="convoluted_lime" x="0%" y="0%" width="100%" height="100%">
<feFlood flood-color="lime"/>
<feConvolveMatrix order="3" kernelMatrix="
0 0 0
0 1 0
0 0 0"/>
</filter>
</defs>
<rect x="30" y="30" width="97" height="60" filter="url(#convoluted_lime)"/>
</svg>

After

Width:  |  Height:  |  Size: 339 B

View File

@ -0,0 +1,18 @@
<svg xmlns="http://www.w3.org/2000/svg" xmlns:html="http://www.w3.org/1999/xhtml">
<desc>
<html:p>When the 'order' attribute of feConvolveMatrix is
omitted the effect is the same as if the value "3" were given.
Per <html:a href="https://bugzilla.mozilla.org/show_bug.cgi?id=478570">Bug 478570</html:a>
discussion and linked spec errata.</html:p>
</desc>
<defs>
<filter id="convoluted_lime" x="0%" y="0%" width="100%" height="100%">
<feFlood flood-color="lime"/>
<feConvolveMatrix kernelMatrix="
0 0 0
0 1 0
0 0 0"/>
</filter>
</defs>
<rect x="30" y="30" width="97" height="60" fill="red" filter="url(#convoluted_lime)"/>
</svg>

After

Width:  |  Height:  |  Size: 663 B

View File

@ -67,3 +67,4 @@ fails == filter-marked-line-01.svg pass.svg # bug 477704
== filter-patterned-rect-01.svg pass.svg
== filter-patterned-rect-02.svg pass.svg
== feConvolveMatrix-order-01.svg feConvolveMatrix-order-01-ref.svg