mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
Bug 998893 - Update the autocomplete search string when pressing DOM_VK_DOWN to initiate a search. r=mak
Some script may have changed the value of the text field since our last keypress or after our focus handler and we don't want to search for a stale string.
This commit is contained in:
parent
a9ce2e9a04
commit
189ecda08b
@ -470,6 +470,13 @@ nsAutoCompleteController::HandleKeyNavigation(uint32_t aKey, bool *_retval)
|
|||||||
return NS_OK;
|
return NS_OK;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Some script may have changed the value of the text field since our
|
||||||
|
// last keypress or after our focus handler and we don't want to search
|
||||||
|
// for a stale string.
|
||||||
|
nsAutoString value;
|
||||||
|
input->GetTextValue(value);
|
||||||
|
mSearchString = value;
|
||||||
|
|
||||||
StartSearches();
|
StartSearches();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -54,6 +54,7 @@ support-files =
|
|||||||
[test_autocomplete3.xul]
|
[test_autocomplete3.xul]
|
||||||
[test_autocomplete4.xul]
|
[test_autocomplete4.xul]
|
||||||
[test_autocomplete5.xul]
|
[test_autocomplete5.xul]
|
||||||
|
[test_autocomplete_change_after_focus.html]
|
||||||
[test_autocomplete_delayOnPaste.xul]
|
[test_autocomplete_delayOnPaste.xul]
|
||||||
[test_autocomplete_with_composition_on_input.html]
|
[test_autocomplete_with_composition_on_input.html]
|
||||||
[test_autocomplete_with_composition_on_textbox.xul]
|
[test_autocomplete_with_composition_on_textbox.xul]
|
||||||
|
@ -0,0 +1,69 @@
|
|||||||
|
<!DOCTYPE html>
|
||||||
|
<html>
|
||||||
|
<!--
|
||||||
|
https://bugzilla.mozilla.org/show_bug.cgi?id=998893
|
||||||
|
-->
|
||||||
|
<head>
|
||||||
|
<meta charset="utf-8">
|
||||||
|
<title>Test for Bug 998893 - Ensure that input.value changes affect autocomplete</title>
|
||||||
|
<script type="application/javascript" src="chrome://mochikit/content/tests/SimpleTest/SimpleTest.js"></script>
|
||||||
|
<script type="application/javascript" src="chrome://mochikit/content/tests/SimpleTest/EventUtils.js"></script>
|
||||||
|
<link rel="stylesheet" type="text/css" href="chrome://global/skin"/>
|
||||||
|
<link rel="stylesheet" type="text/css" href="chrome://mochikit/content/tests/SimpleTest/test.css"/>
|
||||||
|
<script type="application/javascript">
|
||||||
|
/** Test for Bug 998893 **/
|
||||||
|
SimpleTest.waitForExplicitFinish();
|
||||||
|
SimpleTest.waitForFocus(setup);
|
||||||
|
|
||||||
|
function setup() {
|
||||||
|
SpecialPowers.formHistory.update([
|
||||||
|
{ op : "bump", fieldname: "field1", value: "Default text option" },
|
||||||
|
{ op : "bump", fieldname: "field1", value: "New value option" },
|
||||||
|
], {
|
||||||
|
handleCompletion: function() {
|
||||||
|
runTest();
|
||||||
|
},
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function handleEnter(evt) {
|
||||||
|
if (evt.keyCode != KeyEvent.DOM_VK_RETURN) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
info("RETURN received for phase: " + evt.eventPhase);
|
||||||
|
is(evt.target.value, "New value option", "Check that the correct autocomplete entry was used");
|
||||||
|
SimpleTest.finish();
|
||||||
|
}
|
||||||
|
|
||||||
|
function popupShownListener(evt) {
|
||||||
|
info("popupshown");
|
||||||
|
sendKey("DOWN");
|
||||||
|
sendKey("RETURN"); // select the first entry in the popup
|
||||||
|
sendKey("RETURN"); // try to submit the form with the filled value
|
||||||
|
}
|
||||||
|
|
||||||
|
SpecialPowers.addAutoCompletePopupEventListener(window, "popupshown", popupShownListener);
|
||||||
|
|
||||||
|
function runTest() {
|
||||||
|
var field = document.getElementById("field1");
|
||||||
|
field.addEventListener("focus", function onFocus() {
|
||||||
|
info("field focused");
|
||||||
|
field.value = "New value";
|
||||||
|
sendKey("DOWN");
|
||||||
|
});
|
||||||
|
|
||||||
|
field.addEventListener("keypress", handleEnter, true);
|
||||||
|
|
||||||
|
field.focus();
|
||||||
|
}
|
||||||
|
|
||||||
|
</script>
|
||||||
|
</head>
|
||||||
|
<body>
|
||||||
|
<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=998893">Mozilla Bug 998893</a>
|
||||||
|
<p id="display"><input id="field1" value="Default text"></p>
|
||||||
|
<div id="content" style="display: none"></div>
|
||||||
|
<pre id="test">
|
||||||
|
</pre>
|
||||||
|
</body>
|
||||||
|
</html>
|
Loading…
Reference in New Issue
Block a user