mirror of
https://gitlab.winehq.org/wine/wine-gecko.git
synced 2024-09-13 09:24:08 -07:00
Bug 558541 - Simplify some code in js_SetPropertyHelper to make it more understandable. r=jorendorff
This commit is contained in:
parent
fdc7ad5061
commit
1867f9020c
@ -5034,16 +5034,15 @@ js_SetPropertyHelper(JSContext *cx, JSObject *obj, jsid id, uintN defineHow,
|
||||
if (!sprop->writable()) {
|
||||
JS_UNLOCK_SCOPE(cx, scope);
|
||||
|
||||
/* Strict mode: report a read-only strict warning. */
|
||||
if (JS_HAS_STRICT_OPTION(cx))
|
||||
return ReportReadOnly(cx, id, JSREPORT_STRICT | JSREPORT_WARNING);
|
||||
|
||||
/* Just return true per ECMA if not in strict mode. */
|
||||
PCMETER((defineHow & JSDNP_CACHE_RESULT) && JS_PROPERTY_CACHE(cx).rofills++);
|
||||
if (defineHow & JSDNP_CACHE_RESULT) {
|
||||
JS_ASSERT_NOT_ON_TRACE(cx);
|
||||
TRACE_2(SetPropHit, JS_NO_PROP_CACHE_FILL, sprop);
|
||||
}
|
||||
|
||||
/* Warn in strict mode, otherwise do nothing. */
|
||||
if (JS_HAS_STRICT_OPTION(cx))
|
||||
return ReportReadOnly(cx, id, JSREPORT_STRICT | JSREPORT_WARNING);
|
||||
return JS_TRUE;
|
||||
|
||||
#ifdef JS_TRACER
|
||||
|
Loading…
Reference in New Issue
Block a user