wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1123115 - Clarify the ownership of some member variables in task.h; r=bent

Browse Source
This commit is contained in:
Ehsan Akhgari 2015-01-18 14:21:17 -05:00
parent 04ffcffd25
commit 182004b54e
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ipc/chromium/src/base/task.h
View File

@ -197,7 +197,8 @@ class ScopedRunnableMethodFactory : public RevocableStore {
virtual void Run() { DispatchToMethod(obj_, meth_, params_); }
private:
T* obj_;
T* MOZ_UNSAFE_REF("The validity of this pointer must be enforced by "
"external factors.") obj_;
Method meth_;
Params params_;
@ -225,7 +226,8 @@ class DeleteTask : public CancelableTask {
obj_ = NULL;
}
private:
T* obj_;
T* MOZ_UNSAFE_REF("The validity of this pointer must be enforced by "
"external factors.") obj_;
};
// Task to Release() an object
@ -242,7 +244,8 @@ class ReleaseTask : public CancelableTask {
obj_ = NULL;
}
private:
T* obj_;
T* MOZ_UNSAFE_REF("The validity of this pointer must be enforced by "
"external factors.") obj_;
};
// RunnableMethodTraits --------------------------------------------------------
@ -319,7 +322,9 @@ class RunnableMethod : public CancelableTask,
}
}
T* obj_;
// This is owning because of the RetainCallee and ReleaseCallee calls in the
// constructor and destructor.
T* MOZ_OWNING_REF obj_;
Method meth_;
Params params_;
};
@ -513,7 +518,8 @@ class CallbackStorage {
}
protected:
T* obj_;
T* MOZ_UNSAFE_REF("The validity of this pointer must be enforced by "
"external factors.") obj_;
Method meth_;
};