Bug 873338 - JavaDoc and checkstyle warnings. r=trivial

mobile/android/base/background/announcements/AnnouncementsService.java

@@ -127,11 +127,6 @@ public class AnnouncementsService extends BackgroundService implements Announcem
     AnnouncementsFetcher.fetchAndProcessAnnouncements(getLastLaunch(), this);
   }
 
-  @Override
-  public void onDestroy() {
-    super.onDestroy();
-  }
-
   @Override
   public IBinder onBind(Intent intent) {
     return null;

mobile/android/base/background/bagheera/DeflateHelper.java

@@ -43,7 +43,7 @@ public class DeflateHelper {
    * on the output.
    *
    * Note that this method does not trim the output array. (Test code can use
-   * {@link TestDeflation#deflateTrimmed(byte[])}.)
+   * TestDeflation#deflateTrimmed(byte[]).)
    *
    * Trimming would be more efficient for long-term space use, but we expect this
    * entity to be transient.
@@ -54,7 +54,6 @@ public class DeflateHelper {
    * @param bytes the input to deflate.
    * @return the deflated input as an entity.
    */
-  @SuppressWarnings("javadoc")
   public static HttpEntity deflateBytes(final byte[] bytes) {
     // We would like to use DeflaterInputStream here, but it's minSDK=9, and we
     // still target 8. It would also force us to use chunked Transfer-Encoding,

mobile/android/base/background/healthreport/HealthReportGenerator.java

@@ -134,6 +134,7 @@ public class HealthReportGenerator {
             discrete.add(cursor.getLong(3));
           } else {
             // Uh oh!
+            throw new IllegalStateException("Unknown field type: " + field.flags);
           }
         } else {
           if (field.isStringField()) {

mobile/android/base/sync/ExtendedJSONObject.java

@@ -115,7 +115,7 @@ public class ExtendedJSONObject {
   /**
    * Helper method to get a JSON object from a stream.
    *
-   * @param jsonString input.
+   * @param in input {@link Reader}.
    * @throws ParseException
    * @throws IOException
    * @throws NonArrayJSONException if the object is valid JSON, but not an object.