From 12646a378be2beb8db1b8b6ae66da9799669de86 Mon Sep 17 00:00:00 2001
From: Panos Astithas <past@mozilla.com>
Date: Mon, 28 Jul 2014 21:02:29 +0300
Subject: [PATCH] Fix the devtools window title when the options tab is
 selected (bug 1044488); r=jwalker

---
 browser/devtools/framework/toolbox.js                         | 2 +-
 browser/devtools/main.js                                      | 2 ++
 .../locales/en-US/chrome/browser/devtools/toolbox.properties  | 4 ++++
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/browser/devtools/framework/toolbox.js b/browser/devtools/framework/toolbox.js
index e1156f76cf5..b42b98bd579 100644
--- a/browser/devtools/framework/toolbox.js
+++ b/browser/devtools/framework/toolbox.js
@@ -730,7 +730,7 @@ Toolbox.prototype = {
       radio.appendChild(image);
     }
 
-    if (toolDefinition.label) {
+    if (toolDefinition.label && !toolDefinition.iconOnly) {
       let label = this.doc.createElement("label");
       label.setAttribute("value", toolDefinition.label)
       label.setAttribute("crop", "end");
diff --git a/browser/devtools/main.js b/browser/devtools/main.js
index 2c6cbf66781..b9a306cc434 100644
--- a/browser/devtools/main.js
+++ b/browser/devtools/main.js
@@ -70,6 +70,8 @@ Tools.options = {
   icon: "chrome://browser/skin/devtools/tool-options.svg",
   invertIconForLightTheme: true,
   bgTheme: "theme-body",
+  label: l10n("options.label", toolboxStrings),
+  iconOnly: true,
   panelLabel: l10n("options.panelLabel", toolboxStrings),
   tooltip: l10n("optionsButton.tooltip", toolboxStrings),
   inMenu: false,
diff --git a/browser/locales/en-US/chrome/browser/devtools/toolbox.properties b/browser/locales/en-US/chrome/browser/devtools/toolbox.properties
index 92ab2cad34a..c389c815d54 100644
--- a/browser/locales/en-US/chrome/browser/devtools/toolbox.properties
+++ b/browser/locales/en-US/chrome/browser/devtools/toolbox.properties
@@ -43,6 +43,10 @@ toolbox.label=Developer Tools
 # for the options panel tab.
 optionsButton.tooltip=Toolbox Options
 
+# LOCALIZATION NOTE (options.label): This is used as the label of the tab in
+# the devtools window.
+options.label=Options
+
 # LOCALIZATION NOTE (options.panelLabel): This is used as the label for the
 # toolbox panel.
 options.panelLabel=Toolbox Options Panel