From 1044252614a1d96c935b7174649c3a9e4642c112 Mon Sep 17 00:00:00 2001 From: Jim Mathies Date: Fri, 2 Dec 2011 10:23:55 -0600 Subject: [PATCH] Bug 707092 - Add a null check and return proper constants on failure from GetTopLevelWindowActiveState, r=bbondy. --- widget/src/windows/nsNativeThemeWin.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/widget/src/windows/nsNativeThemeWin.cpp b/widget/src/windows/nsNativeThemeWin.cpp index 7932a089195..75e66bac457 100644 --- a/widget/src/windows/nsNativeThemeWin.cpp +++ b/widget/src/windows/nsNativeThemeWin.cpp @@ -89,9 +89,11 @@ static PRInt32 GetTopLevelWindowActiveState(nsIFrame *aFrame) // until it finds a real window. nsIWidget* widget = aFrame->GetNearestWidget(); nsWindow * window = static_cast(widget); + if (!window) + return mozilla::widget::themeconst::FS_INACTIVE; if (widget && !window->IsTopLevelWidget() && !(window = window->GetParentWindow(false))) - return false; + return mozilla::widget::themeconst::FS_INACTIVE; if (window->GetWindowHandle() == ::GetActiveWindow()) return mozilla::widget::themeconst::FS_ACTIVE;