wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1112480 part 4 - Use mPendingReadyTime in AnimationPlayer::Tick; r=jwatt

Browse Source 
This patch makes AnimationPlayer act on requests to StartOnNextTick by checking
for mPendingReadyTime on each tick.

We also check that the ready time is not in the future since currently it might
be possible that we get multiple calls to AnimationPlayer::Tick within a single
refresh driver tick.

Note that this patch shouldn't actually produce any observable change yet,
however, since we don't call StartOnNextTick anywhere.
This commit is contained in:
Brian Birtles 2015-01-09 07:57:58 +09:00
parent 394bebab79
commit 1017f602b8
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dom/animation/AnimationPlayer.cpp
View File

@ -133,6 +133,17 @@ AnimationPlayer::SetSource(Animation* aSource)
void void
AnimationPlayer::Tick() AnimationPlayer::Tick()
{ {
// Since we are not guaranteed to get only one call per refresh driver tick,
// it's possible that mPendingReadyTime is set to a time in the future.
// In that case, we should wait until the next refresh driver tick before
// resuming.
if (mIsPending &&
!mPendingReadyTime.IsNull() &&
mPendingReadyTime.Value() <= mTimeline->GetCurrentTime().Value()) {
ResumeAt(mPendingReadyTime.Value());
mPendingReadyTime.SetNull();
}
// FIXME (bug 1112969): Check if we are pending but have lost access to the // FIXME (bug 1112969): Check if we are pending but have lost access to the
// pending player tracker. If that's the case we should probably trigger the // pending player tracker. If that's the case we should probably trigger the
// animation now. // animation now.
@ -145,9 +156,8 @@ AnimationPlayer::StartOnNextTick(const Nullable<TimeDuration>& aReadyTime)
{ {
// Normally we expect the play state to be pending but it's possible that, // Normally we expect the play state to be pending but it's possible that,
// due to the handling of possibly orphaned players in Tick() [coming // due to the handling of possibly orphaned players in Tick() [coming
// in a later patch in this series], this player // in a later patch in this series], this player got started whilst still
// got started whilst still being in another document's pending player // being in another document's pending player map.
// map.
if (PlayState() != AnimationPlayState::Pending) { if (PlayState() != AnimationPlayState::Pending) {
return; return;
} }