wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 964700 - Make the errors logged by Parser.jsm also contain the problematic source url, r=past

Browse Source
This commit is contained in:
Victor Porof 2014-01-28 13:24:45 +02:00
parent 1eb634dd55
commit 0d06850d93
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
browser/devtools/shared/Parser.jsm
View File

@ -85,7 +85,7 @@ Parser.prototype = {
}
}
let pool = new SyntaxTreesPool(syntaxTrees);
let pool = new SyntaxTreesPool(syntaxTrees, aUrl);
// Cache the syntax trees pool by the specified url. This is entirely
// optional, but it's strongly encouraged to cache ASTs because
@ -123,9 +123,12 @@ Parser.prototype = {
*
* @param object aSyntaxTrees
* A collection of AST nodes generated for a source.
* @param string aUrl [optional]
* The source url.
*/
function SyntaxTreesPool(aSyntaxTrees) {
function SyntaxTreesPool(aSyntaxTrees, aUrl = "<unknown>") {
this._trees = aSyntaxTrees;
this._url = aUrl;
this._cache = new Map();
}
@ -215,7 +218,7 @@ SyntaxTreesPool.prototype = {
// Can't guarantee that the tree traversal logic is forever perfect :)
// Language features may be added, in which case the recursive methods
// need to be updated. If an exception is thrown here, file a bug.
DevToolsUtils.reportException("syntax tree", e);
DevToolsUtils.reportException("Syntax tree visitor for " + aUrl, e);
}
}
this._cache.set(requestId, results);

2
toolkit/devtools/DevToolsUtils.js
View File

@ -29,7 +29,7 @@ this.safeErrorString = function safeErrorString(aError) {
} catch (ee) { }
if (typeof aError.lineNumber == "number" && typeof aError.columnNumber == "number") {
errorString += ", line: " + aError.lineNumber + ", column: " + aError.columnNumber;
errorString += "Line: " + aError.lineNumber + ", column: " + aError.columnNumber;
}
return errorString;