wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1142716 - update/tests/TestAUSHelper.cpp CheckMsg leaks |inFP| and |mbuf|. r=bbondy

Browse Source
This commit is contained in:
Robert Strong 2015-03-18 16:25:05 -07:00
parent 8f53ff74b9
commit 0c5e5bd22f
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
toolkit/mozapps/update/tests/TestAUSHelper.cpp
View File

@ -99,11 +99,15 @@ CheckMsg(const NS_tchar *path, const char *expected)
struct stat ms;
if (fstat(fileno(inFP), &ms)) {
fclose(inFP);
inFP = nullptr;
return false;
}
char *mbuf = (char *) malloc(ms.st_size + 1);
if (!mbuf) {
fclose(inFP);
inFP = nullptr;
return false;
}
@ -113,14 +117,19 @@ CheckMsg(const NS_tchar *path, const char *expected)
r -= c;
rb += c;
if (c == 0 && r) {
free(mbuf);
fclose(inFP);
inFP = nullptr;
return false;
}
mbuf[ms.st_size] = '\0';
rb = mbuf;
bool isMatch = strcmp(rb, expected) == 0;
free(mbuf);
fclose(inFP);
inFP = nullptr;
return strcmp(rb, expected) == 0;
return isMatch;
}
#ifdef XP_WIN