Bug 1217315 - Remove for-each from docshell/. r=smaug

docshell/test/chrome/bug112564_window.xul

@@ -29,7 +29,7 @@
     }
 
     function finish() {
-      for each (let eventType in LISTEN_EVENTS) {
+      for (let eventType of LISTEN_EVENTS) {
         gBrowser.removeEventListener(eventType, eventListener, true);
       }
 
@@ -43,7 +43,7 @@
 
     function onLoad() {
       gBrowser = document.getElementById("content");
-      for each (let eventType in LISTEN_EVENTS) {
+      for (let eventType of LISTEN_EVENTS) {
         gBrowser.addEventListener(eventType, eventListener, true);
       }
              

docshell/test/chrome/bug113934_window.xul

@@ -15,7 +15,7 @@
   <script type="application/javascript"><![CDATA[
     var imports = [ "SimpleTest", "is", "isnot", "ok", "snapshotWindow",
                     "compareSnapshots", "onerror" ];
-    for each (var name in imports) {
+    for (var name of imports) {
       window[name] = window.opener.wrappedJSObject[name];
     }
 

docshell/test/chrome/bug215405_window.xul

@@ -15,7 +15,7 @@
 
   <script type="application/javascript"><![CDATA[
     var imports = [ "SimpleTest", "is", "isnot", "ok"];
-    for each (var name in imports) {
+    for (var name of imports) {
       window[name] = window.opener.wrappedJSObject[name];
     }
 

docshell/test/chrome/bug364461_window.xul

@@ -28,7 +28,7 @@
       window.opener.wrappedJSObject.SimpleTest.is(a, b, message);
     }
     function finish() {
-      for each (let eventType in LISTEN_EVENTS) {
+      for (let eventType of LISTEN_EVENTS) {
         gBrowser.removeEventListener(eventType, eventListener, true);
       }
     
@@ -39,7 +39,7 @@
     function onLoad() {
       gBrowser = document.getElementById("content");
 
-      for each (let eventType in LISTEN_EVENTS) {
+      for (let eventType of LISTEN_EVENTS) {
         gBrowser.addEventListener(eventType, eventListener, true);
       }
       

docshell/test/chrome/bug396519_window.xul

@@ -32,7 +32,7 @@
       window.opener.wrappedJSObject.SimpleTest.is(a, b, message);
     }
     function finish() {
-      for each (let eventType in LISTEN_EVENTS) {
+      for (let eventType of LISTEN_EVENTS) {
         gBrowser.removeEventListener(eventType, eventListener, true);
       }
     
@@ -43,7 +43,7 @@
     function onLoad() {
       gBrowser = document.getElementById("content");
 
-      for each (let eventType in LISTEN_EVENTS) {
+      for (let eventType of LISTEN_EVENTS) {
         gBrowser.addEventListener(eventType, eventListener, true);
       }
       

docshell/test/chrome/bug449778_window.xul

@@ -9,7 +9,7 @@
   <!-- test code goes here -->
   <script type="application/javascript"><![CDATA[
     var imports = [ "SimpleTest", "is", "isnot", "ok", "onerror" ];
-    for each (var name in imports) {
+    for (var name of imports) {
       window[name] = window.opener.wrappedJSObject[name];
     }
 

docshell/test/chrome/bug449780_window.xul

@@ -9,7 +9,7 @@
   <!-- test code goes here -->
   <script type="application/javascript"><![CDATA[
     var imports = [ "SimpleTest", "is", "isnot", "ok", "onerror" ];
-    for each (var name in imports) {
+    for (var name of imports) {
       window[name] = window.opener.wrappedJSObject[name];
     }
 

docshell/test/chrome/bug92598_window.xul

@@ -29,7 +29,7 @@
     }
 
     function finish() {
-      for each (let eventType in LISTEN_EVENTS) {
+      for (let eventType of LISTEN_EVENTS) {
         gBrowser.removeEventListener(eventType, eventListener, true);
       }
      
@@ -43,7 +43,7 @@
 
     function onLoad() {
       gBrowser = document.getElementById("content");
-      for each (let eventType in LISTEN_EVENTS) {
+      for (let eventType of LISTEN_EVENTS) {
         gBrowser.addEventListener(eventType, eventListener, true);
       }
              

docshell/test/chrome/docshell_helpers.js

@@ -3,7 +3,7 @@
  */
 var imports = [ "SimpleTest", "is", "isnot", "ok", "onerror", "todo",
   "todo_is", "todo_isnot" ];
-for each (var name in imports) {
+for (var name of imports) {
   window[name] = window.opener.wrappedJSObject[name];
 }
 
@@ -125,17 +125,21 @@ function doPageNavigation(params) {
     throw "Must specify onNavComplete when specifying waitForEventsOnly";
   if (waitOnly && (back || forward || reload || uri))
     throw "Can't specify a navigation type when using waitForEventsOnly";
-  for each (let anEventType in eventsToListenFor) {
+  for (let anEventType of eventsToListenFor) {
     let eventFound = false;
     if ( (anEventType == "pageshow") && (!gExpectedEvents) )
       eventFound = true;
-    for each (let anExpectedEvent in gExpectedEvents) {
-      if (anExpectedEvent.type == anEventType)
-        eventFound = true;
+    if (gExpectedEvents) {
+      for (let anExpectedEvent of gExpectedEvents) {
+        if (anExpectedEvent.type == anEventType)
+          eventFound = true;
+      }
     }
-    for each (let anExpectedEventType in gUnexpectedEvents) {
-      if (anExpectedEventType == anEventType)
-        eventFound = true;
+    if (gUnexpectedEvents) {
+      for (let anExpectedEventType of gUnexpectedEvents) {
+        if (anExpectedEventType == anEventType)
+          eventFound = true;
+      }
     }
     if (!eventFound)
       throw "Event type " + anEventType + " is specified in " +
@@ -148,7 +152,7 @@ function doPageNavigation(params) {
   
   // Add an event listener for each type of event in the .eventsToListenFor 
   // property of the input parameters.
-  for each (let eventType in eventsToListenFor) {
+  for (let eventType of eventsToListenFor) {
     dump("TEST: registering a listener for " + eventType + " events\n");
     TestWindow.getBrowser().addEventListener(eventType, pageEventListener, 
       true);
@@ -201,7 +205,7 @@ function doPageNavigation_complete(eventsToListenFor, onNavComplete,
   preventBFCache) {
   // Unregister our event listeners.
   dump("TEST: removing event listeners\n");
-  for each (let eventType in eventsToListenFor) {
+  for (let eventType of eventsToListenFor) {
     TestWindow.getBrowser().removeEventListener(eventType, pageEventListener, 
       true);
   }