wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 912918 - Part 1: Code style cleanups in app validator. r=paul

Browse Source
This commit is contained in:
J. Ryan Stinnett 2013-11-04 15:38:29 -06:00
parent f2fbd2c126
commit 09f76db933
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
browser/devtools/app-manager/app-validator.js
View File

@ -1,8 +1,9 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
let {Ci,Cu,CC,Cc} = require("chrome");
let {Ci,Cu,CC} = require("chrome");
const promise = require("sdk/core/promise");
const {FileUtils} = Cu.import("resource://gre/modules/FileUtils.jsm");
@ -18,11 +19,11 @@ function AppValidator(project) {
AppValidator.prototype.error = function (message) {
this.errors.push(message);
}
};
AppValidator.prototype.warning = function (message) {
this.warnings.push(message);
}
};
AppValidator.prototype._getPackagedManifestFile = function () {
let manifestFile = FileUtils.File(this.project.location);
@ -85,7 +86,7 @@ AppValidator.prototype._fetchManifest = function (manifestURL) {
}
return deferred.promise;
}
};
AppValidator.prototype._getManifest = function () {
let manifestURL;
@ -106,7 +107,7 @@ AppValidator.prototype._getManifest = function () {
return promise.resolve(null);
}
return this._fetchManifest(manifestURL);
}
};
AppValidator.prototype.validateManifest = function (manifest) {
if (!manifest.name) {
@ -114,21 +115,21 @@ AppValidator.prototype.validateManifest = function (manifest) {
return;
}
if (!manifest.icons || Object.keys(manifest.icons).length == 0) {
if (!manifest.icons || Object.keys(manifest.icons).length === 0) {
this.warning(strings.GetStringFromName("validator.missIconsManifestProperty"));
} else if (!manifest.icons["128"]) {
this.warning(strings.GetStringFromName("validator.missIconMarketplace"));
}
}
};
AppValidator.prototype._getOriginURL = function (manifest) {
AppValidator.prototype._getOriginURL = function () {
if (this.project.type == "packaged") {
let manifestURL = Services.io.newURI(this.manifestURL, null, null);
return Services.io.newURI(".", null, manifestURL).spec;
} else if (this.project.type == "hosted") {
return Services.io.newURI(this.project.location, null, null).prePath;
}
}
};
AppValidator.prototype.validateLaunchPath = function (manifest) {
let deferred = promise.defer();
@ -181,7 +182,7 @@ AppValidator.prototype.validateLaunchPath = function (manifest) {
}
return deferred.promise;
}
};
AppValidator.prototype.validateType = function (manifest) {
let appType = manifest.type || "web";
@ -196,7 +197,7 @@ AppValidator.prototype.validateType = function (manifest) {
if (appType === "certified") {
this.warning(strings.GetStringFromName("validator.noCertifiedSupport"));
}
}
};
AppValidator.prototype.validate = function () {
this.errors = [];
@ -210,7 +211,6 @@ AppValidator.prototype.validate = function () {
return this.validateLaunchPath(manifest);
}
}).bind(this));
}
};
exports.AppValidator = AppValidator;