wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 867329 - Make JS_NewUint8Array and friends accept any uint32_t as length and throw if the length is too big -- not assert when it's too big. r=sfink

Browse Source
This commit is contained in:
Jeff Walden 2013-04-30 18:15:15 -07:00
parent d349e7c9e0
commit 08885153f0
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/src/jsapi-tests/testTypedArrays.cpp
View File

@ -59,6 +59,11 @@ template<JSObject *Create(JSContext *, uint32_t),
bool
TestPlainTypedArray(JSContext *cx)
{
{
RootedObject notArray(cx, Create(cx, UINT32_MAX));
CHECK(!notArray);
}
RootedObject array(cx, Create(cx, 7));
CHECK(JS_IsTypedArrayObject(array));
RootedObject proto(cx);

3
js/src/jstypedarray.cpp
View File

@ -2201,7 +2201,7 @@ class TypedArrayTemplate
}
static JSObject *
fromLength(JSContext *cx, int32_t nelements)
fromLength(JSContext *cx, uint32_t nelements)
{
RootedObject buffer(cx, createBufferWithSizeAndCount(cx, nelements));
if (!buffer)
@ -3371,7 +3371,6 @@ const JSFunctionSpec _typedArray::jsfuncs[] = { \
#define IMPL_TYPED_ARRAY_JSAPI_CONSTRUCTORS(Name,NativeType) \
JS_FRIEND_API(JSObject *) JS_New ## Name ## Array(JSContext *cx, uint32_t nelements) \
{ \
MOZ_ASSERT(nelements <= INT32_MAX); \
return TypedArrayTemplate<NativeType>::fromLength(cx, nelements); \
} \
JS_FRIEND_API(JSObject *) JS_New ## Name ## ArrayFromArray(JSContext *cx, JSObject *other_)\