wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 807299 - Fix incorrect progressive update cancelling. r=bgirard

Browse Source 
Sometimes the rounding error on display ports is over a pixel - in this case,
progressive updates may be cancelled incorrectly and cause drawing to be missed
until the next invalidation (assuming that isn't also incorrectly cancelled).
This commit is contained in:
Chris Lord 2012-11-07 18:06:57 +00:00
parent f5b4cb0cee
commit 06198ad8de
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
mobile/android/base/gfx/GeckoLayerClient.java
View File

@ -376,16 +376,17 @@ public class GeckoLayerClient
// XXX All sorts of rounding happens inside Gecko that becomes hard to
// account exactly for. Given we align the display-port to tile
// boundaries (and so they rarely vary by sub-pixel amounts), just
// check that values are within a pixel of the display-port bounds.
// check that values are within a couple of pixels of the
// display-port bounds.
// Never abort drawing if we can't be sure we've sent a more recent
// display-port. If we abort updating when we shouldn't, we can end up
// with blank regions on the screen and we open up the risk of entering
// an endless updating cycle.
if (Math.abs(displayPort.getLeft() - x) <= 1 &&
Math.abs(displayPort.getTop() - y) <= 1 &&
Math.abs(displayPort.getBottom() - (y + height)) <= 1 &&
Math.abs(displayPort.getRight() - (x + width)) <= 1) {
if (Math.abs(displayPort.getLeft() - x) <= 2 &&
Math.abs(displayPort.getTop() - y) <= 2 &&
Math.abs(displayPort.getBottom() - (y + height)) <= 2 &&
Math.abs(displayPort.getRight() - (x + width)) <= 2) {
return mProgressiveUpdateData;
}