From 02047a72be1cc0be7547e30e82ff110a0e3a2549 Mon Sep 17 00:00:00 2001 From: Eric Rahm Date: Thu, 14 May 2015 10:13:23 -0700 Subject: [PATCH] Bug 1163201 - Part 3: Remove mSamples in |MediaEngineWebRTCAudioSource|. r=cpeterson |mSamples| was made protected just to satisfy a warning if PR_LOGGING was not set. As it turns out the warning is correct and mSamples is not used, so lets remove it. --- dom/media/webrtc/MediaEngineWebRTC.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/dom/media/webrtc/MediaEngineWebRTC.h b/dom/media/webrtc/MediaEngineWebRTC.h index c66ce683f1a..7a8cac647fa 100644 --- a/dom/media/webrtc/MediaEngineWebRTC.h +++ b/dom/media/webrtc/MediaEngineWebRTC.h @@ -137,7 +137,6 @@ public: MediaEngineWebRTCAudioSource(nsIThread* aThread, webrtc::VoiceEngine* aVoiceEnginePtr, int aIndex, const char* name, const char* uuid) : MediaEngineAudioSource(kReleased) - , mSamples(0) , mVoiceEngine(aVoiceEnginePtr) , mMonitor("WebRTCMic.Monitor") , mThread(aThread) @@ -199,12 +198,6 @@ public: protected: ~MediaEngineWebRTCAudioSource() { Shutdown(); } - // mSamples is an int to avoid conversions when comparing/etc to - // samplingFreq & length. Making mSamples protected instead of private is a - // silly way to avoid -Wunused-private-field warnings when PR_LOGGING is not - // #defined. mSamples is not actually expected to be used by a derived class. - int mSamples; - private: void Init(); void Shutdown();