Bug 991983 - Remove commented code in gyp_reader.py. r=gps

This code has been commented since it landed, and enabling it requires
adding the proper conditionals around all non_unified_sources in gyp
configurations, which is a daunting task. OTOH, the commented code is
already outdated (it would need updates to work) and the related code
that is not commented gets in the way of upcoming changes, so remove
it.
This commit is contained in:
Mike Hommey 2015-05-15 09:45:04 +09:00
parent 7eb78fb384
commit 01e9c71a20

View File

@ -83,7 +83,6 @@ def read_from_gyp(config, path, output, vars, non_unified_sources = set()):
"""
time_start = time.time()
all_sources = set()
# gyp expects plain str instead of unicode. The frontend code gives us
# unicode strings, so convert them.
@ -164,7 +163,6 @@ def read_from_gyp(config, path, output, vars, non_unified_sources = set()):
unified_sources = sources - non_unified_sources - asm_sources
sources -= unified_sources
all_sources |= sources
# The context expects alphabetical order when adding sources
context['SOURCES'] = alphabetical_sorted(sources)
context['UNIFIED_SOURCES'] = alphabetical_sorted(unified_sources)
@ -235,7 +233,3 @@ def read_from_gyp(config, path, output, vars, non_unified_sources = set()):
context.execution_time = time.time() - time_start
yield context
time_start = time.time()
# remainder = non_unified_sources - all_sources
# if remainder:
# raise SandboxValidationError('%s defined as non_unified_source, but is '
# 'not defined as a source' % ', '.join(remainder))