From b55d6994518b50af2044a9848a1faed9e441e0e5 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Sun, 10 Sep 2023 07:41:31 -0700 Subject: [PATCH] Fix regression in force mouse selection Shift+left click is means to force terminal selection and not passthrough any mouse events, even if a mouse mode is enabled. The change this is reverting from #4583 caused this feature to break by always installing a global listener on Terminal.element so the SelectionService never got a chance to cancel is. Fixes #4781 --- src/browser/Terminal.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/browser/Terminal.ts b/src/browser/Terminal.ts index a092e1bc..131774f1 100644 --- a/src/browser/Terminal.ts +++ b/src/browser/Terminal.ts @@ -729,10 +729,8 @@ export class Terminal extends CoreTerminal implements ITerminal { if (!(events & CoreMouseEventType.UP)) { this._document!.removeEventListener('mouseup', requestedEvents.mouseup!); - el.removeEventListener('mouseup', requestedEvents.mouseup!); requestedEvents.mouseup = null; } else if (!requestedEvents.mouseup) { - el.addEventListener('mouseup', eventListeners.mouseup); requestedEvents.mouseup = eventListeners.mouseup; }