From f69fcb971c20fd87ee02591bd2d68ad52682907d Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Mon, 11 Sep 2023 13:03:57 -0500 Subject: [PATCH] get voiceover to announce terminal output consistently (#4789) * fix #3247 * rm import --- src/browser/AccessibilityManager.ts | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/browser/AccessibilityManager.ts b/src/browser/AccessibilityManager.ts index 60ba9ffc..c878bd0a 100644 --- a/src/browser/AccessibilityManager.ts +++ b/src/browser/AccessibilityManager.ts @@ -5,7 +5,6 @@ import * as Strings from 'browser/LocalizableStrings'; import { ITerminal, IRenderDebouncer } from 'browser/Types'; -import { isMac } from 'common/Platform'; import { TimeBasedDebouncer } from 'browser/TimeBasedDebouncer'; import { Disposable, toDisposable } from 'common/Lifecycle'; import { ScreenDprMonitor } from 'browser/ScreenDprMonitor'; @@ -133,26 +132,12 @@ export class AccessibilityManager extends Disposable { this._liveRegion.textContent += Strings.tooMuchOutput; } } - - // Only detach/attach on mac as otherwise messages can go unaccounced - if (isMac) { - if (this._liveRegion.textContent && this._liveRegion.textContent.length > 0 && !this._liveRegion.parentNode) { - setTimeout(() => { - this._accessibilityContainer.appendChild(this._liveRegion); - }, 0); - } - } } } private _clearLiveRegion(): void { this._liveRegion.textContent = ''; this._liveRegionLineCount = 0; - - // Only detach/attach on mac as otherwise messages can go unaccounced - if (isMac) { - this._liveRegion.remove(); - } } private _handleKey(keyChar: string): void {