From 048e95e34b55307fb72ca8b816ced8a31c8a8965 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 3 Jul 2019 10:23:53 -0700 Subject: [PATCH] Remove blankLine localized string Using a nbsp is more correct and lets the screen reader handle how it wants Fixes #2260 --- src/AccessibilityManager.ts | 6 +++++- src/browser/LocalizableStrings.ts | 1 - typings/xterm.d.ts | 5 ----- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/AccessibilityManager.ts b/src/AccessibilityManager.ts index 9124a477..915a86d6 100644 --- a/src/AccessibilityManager.ts +++ b/src/AccessibilityManager.ts @@ -258,7 +258,11 @@ export class AccessibilityManager extends Disposable { const posInSet = (buffer.ydisp + i + 1).toString(); const element = this._rowElements[i]; if (element) { - element.textContent = lineData.length === 0 ? Strings.blankLine : lineData; + if (lineData.length === 0) { + element.innerHTML = ' '; + } else { + element.textContent = lineData; + } element.setAttribute('aria-posinset', posInSet); element.setAttribute('aria-setsize', setSize); } diff --git a/src/browser/LocalizableStrings.ts b/src/browser/LocalizableStrings.ts index 86f0ebe1..8e782333 100644 --- a/src/browser/LocalizableStrings.ts +++ b/src/browser/LocalizableStrings.ts @@ -3,6 +3,5 @@ * @license MIT */ -export let blankLine = 'Blank line'; export let promptLabel = 'Terminal input'; export let tooMuchOutput = 'Too much output to announce, navigate to rows manually to read'; diff --git a/typings/xterm.d.ts b/typings/xterm.d.ts index be301884..6ef10b62 100644 --- a/typings/xterm.d.ts +++ b/typings/xterm.d.ts @@ -316,11 +316,6 @@ declare module 'xterm' { * The set of localizable strings. */ export interface ILocalizableStrings { - /** - * Announcement for a blank line when `screenReaderMode` is enabled. - */ - blankLine: string; - /** * The aria label for the underlying input textarea for the terminal. */