From efac5293c0bff80c6011b98616821f67c5a692d1 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 1 Mar 2017 09:37:16 -0800 Subject: [PATCH 1/2] Use text cursor for invalid links Part of #570 --- src/xterm.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xterm.css b/src/xterm.css index 0401e607..b7f120f9 100644 --- a/src/xterm.css +++ b/src/xterm.css @@ -82,7 +82,7 @@ } .terminal a.xterm-invalid-link:hover { - cursor: default; + cursor: text; text-decoration: none; } From dcffaf1c8c4d0c78c22e65eb59f13a5a841eef1a Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 1 Mar 2017 09:38:59 -0800 Subject: [PATCH 2/2] Ensure linkElement exists before firing validation callback --- src/Linkifier.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Linkifier.ts b/src/Linkifier.ts index f8b8ca89..38b7e286 100644 --- a/src/Linkifier.ts +++ b/src/Linkifier.ts @@ -141,7 +141,7 @@ export class Linkifier { if (uri) { const linkElement = this._doLinkifyRow(rowIndex, uri, matcher.handler); // Fire validation callback - if (matcher.validationCallback) { + if (linkElement && matcher.validationCallback) { matcher.validationCallback(uri, isValid => { if (!isValid) { linkElement.classList.add(INVALID_LINK_CLASS);