From e6d339a28954eec0290fe7a9c454b326d97fd130 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Mon, 19 Nov 2018 16:54:53 -0800 Subject: [PATCH] Fix wide char caching in webgl renderer --- src/renderer/webgl/GlyphRenderer.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/renderer/webgl/GlyphRenderer.ts b/src/renderer/webgl/GlyphRenderer.ts index 0600f758..b6e4066d 100644 --- a/src/renderer/webgl/GlyphRenderer.ts +++ b/src/renderer/webgl/GlyphRenderer.ts @@ -162,13 +162,13 @@ export class GlyphRenderer { this._updateCell(this._vertices.attributes, x, y, code, attr, bg, fg, chars); } - private _updateCell(array: Float32Array, x: number, y: number, code: number, attr: number, bg: number, fg: number, chars?: string): void { + private _updateCell(array: Float32Array, x: number, y: number, code: number | undefined, attr: number, bg: number, fg: number, chars?: string): void { const terminal = this._terminal; const i = ((y * terminal.cols) + x) * INDICES_PER_CELL; // Exit early if this is a null/space character - if (code === NULL_CELL_CODE) { + if (code === NULL_CELL_CODE || code === undefined/* This is used for the right side of wide chars */) { array.fill(0, i, i + INDICES_PER_CELL - 1); return; }