From d8eedfa1c774415074837a66cd3107d706b42189 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Tue, 31 Jul 2018 10:56:37 -0700 Subject: [PATCH] Fix bug in column selection rendering Fixes #1593 --- src/renderer/SelectionRenderLayer.ts | 2 +- src/renderer/dom/DomRenderer.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/renderer/SelectionRenderLayer.ts b/src/renderer/SelectionRenderLayer.ts index 12589aa0..81782ee8 100644 --- a/src/renderer/SelectionRenderLayer.ts +++ b/src/renderer/SelectionRenderLayer.ts @@ -72,7 +72,7 @@ export class SelectionRenderLayer extends BaseRenderLayer { this._ctx.fillStyle = this._colors.selection.css; if (columnSelectMode) { - const startCol = viewportStartRow === viewportCappedStartRow ? start[0] : 0; + const startCol = start[0]; const width = end[0] - startCol; const height = viewportCappedEndRow - viewportCappedStartRow + 1; this.fillCells(startCol, viewportCappedStartRow, width, height); diff --git a/src/renderer/dom/DomRenderer.ts b/src/renderer/dom/DomRenderer.ts index e336c79e..2679e88e 100644 --- a/src/renderer/dom/DomRenderer.ts +++ b/src/renderer/dom/DomRenderer.ts @@ -241,14 +241,14 @@ export class DomRenderer extends EventEmitter implements IRenderer { // Create the selections const documentFragment = document.createDocumentFragment(); - const startCol = viewportStartRow === viewportCappedStartRow ? start[0] : 0; if (columnSelectMode) { documentFragment.appendChild( - this._createSelectionElement(viewportCappedStartRow, startCol, end[0], viewportCappedEndRow - viewportStartRow + 1) + this._createSelectionElement(viewportCappedStartRow, start[0], end[0], viewportCappedEndRow - viewportCappedStartRow + 1) ); } else { // Draw first row + const startCol = viewportStartRow === viewportCappedStartRow ? start[0] : 0; const endCol = viewportCappedStartRow === viewportCappedEndRow ? end[0] : this._terminal.cols; documentFragment.appendChild(this._createSelectionElement(viewportCappedStartRow, startCol, endCol)); // Draw middle rows