From d8cf3af555a88056bdb2b93d9253b0e8ef9ee0f6 Mon Sep 17 00:00:00 2001
From: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Date: Sat, 8 Oct 2022 10:23:19 -0700
Subject: [PATCH] Fix Marker.dispose

---
 src/common/buffer/Marker.ts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/common/buffer/Marker.ts b/src/common/buffer/Marker.ts
index e639a684..0629e26a 100644
--- a/src/common/buffer/Marker.ts
+++ b/src/common/buffer/Marker.ts
@@ -16,8 +16,7 @@ export class Marker implements IMarker {
   private _id: number = Marker._nextId++;
   public get id(): number { return this._id; }
 
-
-  private readonly _onDispose = new EventEmitter<void>();
+  private readonly _onDispose = this.register(new EventEmitter<void>());
   public readonly onDispose = this._onDispose.event;
 
   constructor(
@@ -34,10 +33,11 @@ export class Marker implements IMarker {
     // Emit before super.dispose such that dispose listeners get a change to react
     this._onDispose.fire();
     disposeArray(this._disposables);
-  }
-
-  public register(disposable: IDisposable): void {
-    this._disposables.push(disposable);
     this._disposables.length = 0;
   }
+
+  public register<T extends IDisposable>(disposable: T): T {
+    this._disposables.push(disposable);
+    return disposable;
+  }
 }