From 3dc52184e5b4d66519ec26b7571d554c22b83e74 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Thu, 25 Jul 2019 16:49:26 -0700 Subject: [PATCH] Fix NPE on dispose when it hasn't been opened --- src/Terminal.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Terminal.ts b/src/Terminal.ts index 49b451ba..f857130b 100644 --- a/src/Terminal.ts +++ b/src/Terminal.ts @@ -270,7 +270,9 @@ export class Terminal extends Disposable implements ITerminal, IDisposable, IInp this._windowsMode.dispose(); this._windowsMode = undefined; } - this._renderService.dispose(); + if (this._renderService) { + this._renderService.dispose(); + } this._customKeyEventHandler = null; this.write = () => {}; if (this.element && this.element.parentNode) {