From 7701557b995f5044e99d02db22337754cfe56857 Mon Sep 17 00:00:00 2001 From: Arek Ouzounian Date: Fri, 6 Jan 2023 14:56:20 -0800 Subject: [PATCH 1/2] Fix for #2488. Use element offsetHeight rather than getBoundingRect --- src/browser/services/CharSizeService.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/browser/services/CharSizeService.ts b/src/browser/services/CharSizeService.ts index 45bbe840..667e826c 100644 --- a/src/browser/services/CharSizeService.ts +++ b/src/browser/services/CharSizeService.ts @@ -77,7 +77,11 @@ class DomMeasureStrategy implements IMeasureStrategy { this._measureElement.style.fontSize = `${this._optionsService.rawOptions.fontSize}px`; // Note that this triggers a synchronous layout - const geometry = this._measureElement.getBoundingClientRect(); + const geometry = { + height: Number(this._measureElement.offsetHeight), + width: Number(this._measureElement.offsetWidth), + } + // If values are 0 then the element is likely currently display:none, in which case we should // retain the previous value. From 79d2f738a24b05697301636b8054b0dc2f5c2104 Mon Sep 17 00:00:00 2001 From: Arek Ouzounian Date: Fri, 6 Jan 2023 15:22:02 -0800 Subject: [PATCH 2/2] fixed linter warnings --- src/browser/services/CharSizeService.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/browser/services/CharSizeService.ts b/src/browser/services/CharSizeService.ts index 667e826c..a4497ed4 100644 --- a/src/browser/services/CharSizeService.ts +++ b/src/browser/services/CharSizeService.ts @@ -79,9 +79,8 @@ class DomMeasureStrategy implements IMeasureStrategy { // Note that this triggers a synchronous layout const geometry = { height: Number(this._measureElement.offsetHeight), - width: Number(this._measureElement.offsetWidth), - } - + width: Number(this._measureElement.offsetWidth) + }; // If values are 0 then the element is likely currently display:none, in which case we should // retain the previous value.