From 55303647c129d706828bf7bf368f1e31372fd4db Mon Sep 17 00:00:00 2001
From: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Date: Thu, 11 Jul 2024 11:15:37 -0700
Subject: [PATCH] Remove overflow to allow decorations outside terminal

This is needed in the demo to show the red test decoration and in vscode for
shell integration decorations/quick fixes
---
 src/vs/base/browser/ui/scrollbar/scrollableElement.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts b/src/vs/base/browser/ui/scrollbar/scrollableElement.ts
index d7d77e6f..b18d8022 100644
--- a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts
+++ b/src/vs/base/browser/ui/scrollbar/scrollableElement.ts
@@ -206,7 +206,8 @@ export abstract class AbstractScrollableElement extends Widget {
 
 	protected constructor(element: HTMLElement, options: ScrollableElementCreationOptions, scrollable: Scrollable) {
 		super();
-		element.style.overflow = 'hidden';
+		// HACK: xterm.js currnetly requires overflow to allow decorations to escape the container
+		// element.style.overflow = 'hidden';
 		this._options = resolveOptions(options);
 		this._scrollable = scrollable;
 
@@ -228,7 +229,8 @@ export abstract class AbstractScrollableElement extends Widget {
 		this._domNode.className = 'xterm-scrollable-element ' + this._options.className;
 		this._domNode.setAttribute('role', 'presentation');
 		this._domNode.style.position = 'relative';
-		this._domNode.style.overflow = 'hidden';
+		// HACK: xterm.js currnetly requires overflow to allow decorations to escape the container
+		// this._domNode.style.overflow = 'hidden';
 		this._domNode.appendChild(element);
 		this._domNode.appendChild(this._horizontalScrollbar.domNode.domNode);
 		this._domNode.appendChild(this._verticalScrollbar.domNode.domNode);