From c3d8c2a919bef1c21f20c77f5196c87cc2422813 Mon Sep 17 00:00:00 2001
From: tisilent <tisilent@163.com>
Date: Fri, 11 Aug 2023 15:47:50 +0800
Subject: [PATCH] Update test and fix

---
 .../dom/DomRendererRowFactory.test.ts         | 23 +++++++++++++++----
 .../renderer/dom/DomRendererRowFactory.ts     |  1 +
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/src/browser/renderer/dom/DomRendererRowFactory.test.ts b/src/browser/renderer/dom/DomRendererRowFactory.test.ts
index e95952f2..609a5b4a 100644
--- a/src/browser/renderer/dom/DomRendererRowFactory.test.ts
+++ b/src/browser/renderer/dom/DomRendererRowFactory.test.ts
@@ -73,11 +73,26 @@ describe('DomRendererRowFactory', () => {
     });
 
     it('should add class for inactive cursor', () => {
-      for (const inactiveStyle of ['outline', 'line', 'underline', 'none']){
+      const coreBrowserService = new MockCoreBrowserService();
+      coreBrowserService.isFocused = false;
+      const rowFactory = new DomRendererRowFactory(
+        dom.window.document,
+        new MockCharacterJoinerService(),
+        new MockOptionsService({ drawBoldTextInBrightColors: true }),
+        coreBrowserService,
+        new MockCoreService(),
+        new MockDecorationService(),
+        new MockThemeService()
+      );
+      for (const inactiveStyle of ['outline', 'block', 'bar', 'underline', 'none']){
         const spans = rowFactory.createRow(lineData, 0, true, 'block', inactiveStyle, 0, false, 5, EMPTY_WIDTH, -1, -1);
-        assert.equal(extractHtml(spans),
-          `<span class="xterm-cursor xterm-cursor-block xterm-cursor-inactive-${inactiveStyle}"> </span>`
-        );
+        if (inactiveStyle === 'none') {
+          assert.equal(extractHtml(spans),
+            `<span class="xterm-cursor"> </span>`);
+        } else {
+          assert.equal(extractHtml(spans),
+            `<span class="xterm-cursor xterm-cursor-${inactiveStyle}"> </span>`);
+        }
       }
     });
 
diff --git a/src/browser/renderer/dom/DomRendererRowFactory.ts b/src/browser/renderer/dom/DomRendererRowFactory.ts
index 89468dd4..41e66b96 100644
--- a/src/browser/renderer/dom/DomRendererRowFactory.ts
+++ b/src/browser/renderer/dom/DomRendererRowFactory.ts
@@ -218,6 +218,7 @@ export class DomRendererRowFactory {
                 break;
               case 'block':
                 classes.push(RowCss.CURSOR_STYLE_BLOCK_CLASS);
+                break;
               case 'bar':
                 classes.push(RowCss.CURSOR_STYLE_BAR_CLASS);
                 break;