From e8a99945830de257a62f0554183b71ee613776fc Mon Sep 17 00:00:00 2001 From: Asad Memon Date: Thu, 4 Apr 2019 11:58:19 -0700 Subject: [PATCH 1/3] add CodeInterview.io in README --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 40de04cf..5083a9e3 100644 --- a/README.md +++ b/README.md @@ -155,6 +155,7 @@ Xterm.js is used in several world-class applications to provide great terminal e - [**info-beamer hosted**](https://info-beamer.com): Uses xterm.js to manage digital signage devices from the web dashboard. - [**Jumpserver**](https://github.com/jumpserver/luna): Jumpserver Luna project, Jumpserver is a bastion server project, Luna use xterm.js for web terminal emulation. - [**LxdMosaic**](https://github.com/turtle0x1/LxdMosaic): Uses xterm.js to give terminal access to containers through LXD +- [**CodeInterview.io**](https://codeinterview.io): A coding interview platform in 25+ languages and many web frameworks. Uses xterm.js to provide shell access. [And much more...](https://github.com/xtermjs/xterm.js/network/dependents) From ddd02b49683a357f41f4c8577ef9b2555be7584b Mon Sep 17 00:00:00 2001 From: Nick Mitchell Date: Sat, 6 Apr 2019 16:04:50 -0400 Subject: [PATCH 2/3] feat: add DIM support to DomRenderer part of #1896 --- src/renderer/dom/DomRendererRowFactory.ts | 5 +++++ src/xterm.css | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/src/renderer/dom/DomRendererRowFactory.ts b/src/renderer/dom/DomRendererRowFactory.ts index 47232981..707d3466 100644 --- a/src/renderer/dom/DomRendererRowFactory.ts +++ b/src/renderer/dom/DomRendererRowFactory.ts @@ -10,6 +10,7 @@ import { DEFAULT_COLOR, INVERTED_DEFAULT_COLOR } from '../atlas/Types'; import { CellData } from '../../BufferLine'; export const BOLD_CLASS = 'xterm-bold'; +export const DIM_CLASS = 'xterm-dim'; export const ITALIC_CLASS = 'xterm-italic'; export const CURSOR_CLASS = 'xterm-cursor'; export const CURSOR_BLINK_CLASS = 'xterm-cursor-blink'; @@ -107,6 +108,10 @@ export class DomRendererRowFactory { charElement.classList.add(ITALIC_CLASS); } + if (flags & FLAGS.DIM) { + charElement.classList.add(exports.DIM_CLASS); + } + charElement.textContent = this._workCell.getChars() || WHITESPACE_CELL_CHAR; if (fg !== DEFAULT_COLOR) { charElement.classList.add(`xterm-fg-${fg}`); diff --git a/src/xterm.css b/src/xterm.css index 2e47b1a1..e0319f87 100644 --- a/src/xterm.css +++ b/src/xterm.css @@ -161,3 +161,7 @@ height: 1px; overflow: hidden; } + +.xterm-dim { + opacity: 0.6; +} From 92c435a16dfa6d7ae366db66985d2d6b6a2247fd Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Sun, 7 Apr 2019 09:45:54 -0400 Subject: [PATCH 3/3] Use same dim opacity as canvas renderer --- src/renderer/dom/DomRendererRowFactory.ts | 2 +- src/xterm.css | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/renderer/dom/DomRendererRowFactory.ts b/src/renderer/dom/DomRendererRowFactory.ts index 707d3466..4d2143ee 100644 --- a/src/renderer/dom/DomRendererRowFactory.ts +++ b/src/renderer/dom/DomRendererRowFactory.ts @@ -109,7 +109,7 @@ export class DomRendererRowFactory { } if (flags & FLAGS.DIM) { - charElement.classList.add(exports.DIM_CLASS); + charElement.classList.add(DIM_CLASS); } charElement.textContent = this._workCell.getChars() || WHITESPACE_CELL_CHAR; diff --git a/src/xterm.css b/src/xterm.css index e0319f87..e80c2524 100644 --- a/src/xterm.css +++ b/src/xterm.css @@ -163,5 +163,5 @@ } .xterm-dim { - opacity: 0.6; + opacity: 0.5; }