diff --git a/demo/client.ts b/demo/client.ts index 70588213..f3f11806 100644 --- a/demo/client.ts +++ b/demo/client.ts @@ -555,7 +555,7 @@ function addDecoration() { } function addOverviewRuler() { - term.options['overviewRulerWidth'] = 15; + term.options['overviewRulerWidth'] = 13; const canvas = term.registerDecoration({marker: term.addMarker(1), overviewRulerOptions: { color: 'red' }}); term.registerDecoration({marker: term.addMarker(3), overviewRulerOptions: { color: 'green' }}); term.registerDecoration({marker: term.addMarker(5), overviewRulerOptions: { color: 'blue' }}); diff --git a/test/api/Terminal.api.ts b/test/api/Terminal.api.ts index 0a6732d7..f13b2ada 100644 --- a/test/api/Terminal.api.ts +++ b/test/api/Terminal.api.ts @@ -732,7 +732,7 @@ describe('API Integration Tests', function(): void { }); describe('registerDecoration', () => { - it('should register decorations and not render them', async () => { + it('should register decorations and render them', async () => { await openTerminal(page); await writeSync(page, '\\n\\n\\n\\n'); await writeSync(page, '\\n\\n\\n\\n'); @@ -742,17 +742,7 @@ describe('API Integration Tests', function(): void { await page.evaluate(`window.term.registerDecoration({ marker: window.marker1 })`); await page.evaluate(`window.term.registerDecoration({ marker: window.marker2 })`); await page.evaluate(`window.term.resize(10, 5)`); - assert.equal(await page.evaluate(`document.querySelectorAll('.xterm-screen .xterm-decoration').length`), 0); - }); - it('on resize should dispose of the old decoration and create a new one', async () => { - await openTerminal(page); - await writeSync(page, '\\n\\n\\n\\n'); - await writeSync(page, '\\n\\n\\n\\n'); - await page.evaluate(`window.marker = window.term.addMarker(1)`); - await page.evaluate(`window.decoration = window.term.registerDecoration({ marker: window.marker })`); - await page.evaluate(`window.term.open(document.querySelector('#terminal-container'))`); - await page.evaluate(`window.term.resize(10, 5)`); - assert.equal(await page.evaluate(`document.querySelectorAll('.xterm-screen .xterm-decoration').length`), 1); + assert.equal(await page.evaluate(`document.querySelectorAll('.xterm-screen .xterm-decoration').length`), 2); }); it('should return undefined when the marker has already been disposed of', async () => { await openTerminal(page);