From bc1d87dade613ad7cd80c76cda7f3d8a41d0da19 Mon Sep 17 00:00:00 2001 From: Anthony Kim Date: Thu, 22 Jan 2026 23:38:10 -0800 Subject: [PATCH] comments --- addons/addon-kitty-graphics/src/KittyGraphicsAddon.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/addons/addon-kitty-graphics/src/KittyGraphicsAddon.ts b/addons/addon-kitty-graphics/src/KittyGraphicsAddon.ts index 3cf76f24..cbfac5d6 100644 --- a/addons/addon-kitty-graphics/src/KittyGraphicsAddon.ts +++ b/addons/addon-kitty-graphics/src/KittyGraphicsAddon.ts @@ -62,7 +62,9 @@ export function parseKittyCommand(data: string): IKittyCommand { const value = part.substring(eqIdx + 1); switch (key) { + // These are key(s) from: https://sw.kovidgoyal.net/kitty/graphics-protocol/#control-data-reference // Question: How do we know which radix to use? + // TODO: Support more keys like type of compression, animations, etc case 'a': cmd.action = value; break; case 'f': cmd.format = parseInt(value); break; case 'i': cmd.id = parseInt(value); break; @@ -84,6 +86,8 @@ export class KittyGraphicsAddon implements ITerminalAddon, IKittyGraphicsApi { private _terminal: ITerminalExt | undefined; private _apcHandler: IDisposable | undefined; private _renderer: KittyImageRenderer | undefined; + // Question: ImageAddon has ImageStorage, lot going on there though comapred to IKittyImage atm. + // Maybe add more, rename to IKittyImageStorage instead of IKittyImage? private _images: Map = new Map(); private _decodedImages: Map = new Map(); private _pendingData: Map = new Map(); @@ -142,6 +146,7 @@ export class KittyGraphicsAddon implements ITerminalAddon, IKittyGraphicsApi { const action = cmd.action || 't'; + // Actions from: https://sw.kovidgoyal.net/kitty/graphics-protocol/#control-data-reference switch (action) { case KittyAction.TRANSMIT: return this._handleTransmit(cmd);