diff --git a/src/common/services/DecorationService.ts b/src/common/services/DecorationService.ts index d251dc35..fb7373bf 100644 --- a/src/common/services/DecorationService.ts +++ b/src/common/services/DecorationService.ts @@ -75,7 +75,6 @@ class Decoration extends Disposable implements IInternalDecoration { private _onDispose = this.register(new EventEmitter()); public readonly onDispose = this._onDispose.event; - // TODO: React to changes on options private _cachedBg: IColor | undefined | null = null; public get backgroundColorRGB(): IColor | undefined { if (this._cachedBg === null) { @@ -88,7 +87,6 @@ class Decoration extends Disposable implements IInternalDecoration { return this._cachedBg; } - // TODO: React to changes on options private _cachedFg: IColor | undefined | null = null; public get foregroundColorRGB(): IColor | undefined { if (this._cachedFg === null) { diff --git a/typings/xterm.d.ts b/typings/xterm.d.ts index fe1bb979..2de77989 100644 --- a/typings/xterm.d.ts +++ b/typings/xterm.d.ts @@ -445,7 +445,6 @@ declare module 'xterm' { * were provided initially. */ options: Pick; - // options: Pick; } @@ -493,13 +492,13 @@ declare module 'xterm' { * The background color of the cell(s). When 2 decorations both set the foreground color the * last registered decoration will be used. Only the `#RRGGBB` format is supported. */ - backgroundColor?: string; + readonly backgroundColor?: string; /** * The foreground color of the cell(s). When 2 decorations both set the foreground color the * last registered decoration will be used. Only the `#RRGGBB` format is supported. */ - foregroundColor?: string; + readonly foregroundColor?: string; /** * When defined, renders the decoration in the overview ruler to the right