From b85f5aacd62c753ca59d4a7bf2b105ae084acfd4 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 10 May 2022 06:14:53 -0700 Subject: [PATCH] Use correct row for override in canvas renderer --- src/browser/renderer/Renderer.ts | 1 - src/browser/renderer/TextRenderLayer.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/browser/renderer/Renderer.ts b/src/browser/renderer/Renderer.ts index a58893b4..8dfe09c9 100644 --- a/src/browser/renderer/Renderer.ts +++ b/src/browser/renderer/Renderer.ts @@ -14,7 +14,6 @@ import { ICharSizeService } from 'browser/services/Services'; import { IBufferService, IOptionsService, IInstantiationService } from 'common/services/Services'; import { removeTerminalFromCache } from 'browser/renderer/atlas/CharAtlasCache'; import { EventEmitter, IEvent } from 'common/EventEmitter'; -import { IDecorationOptions, IDecoration } from 'xterm'; let nextRendererId = 1; diff --git a/src/browser/renderer/TextRenderLayer.ts b/src/browser/renderer/TextRenderLayer.ts index e0f6d831..e94b53e0 100644 --- a/src/browser/renderer/TextRenderLayer.ts +++ b/src/browser/renderer/TextRenderLayer.ts @@ -179,7 +179,7 @@ export class TextRenderLayer extends BaseRenderLayer { // Get any decoration foreground/background overrides, this must be fetched before the early // exist but applied after inverse - const decorations = this._decorationService.getDecorationsOnLine(y); + const decorations = this._decorationService.getDecorationsOnLine(this._bufferService.buffer.ydisp + y); for (const d of decorations) { const xmin = d.options.x ?? 0; const xmax = xmin + (d.options.width ?? 1);