From b59de22c36ac376ff83bec563c0cb2a2dcb5429c Mon Sep 17 00:00:00 2001 From: greenmashimaro Date: Tue, 23 Aug 2022 15:09:43 +0800 Subject: [PATCH 1/4] fix typo --- src/common/buffer/BufferSet.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/buffer/BufferSet.ts b/src/common/buffer/BufferSet.ts index 7d07cec8..f940bb8f 100644 --- a/src/common/buffer/BufferSet.ts +++ b/src/common/buffer/BufferSet.ts @@ -58,14 +58,14 @@ export class BufferSet extends Disposable implements IBufferSet { } /** - * Returns the normal Buffer of the BufferSet + * Returns the currently active Buffer of the BufferSet */ public get active(): Buffer { return this._activeBuffer; } /** - * Returns the currently active Buffer of the BufferSet + * Returns the normal Buffer of the BufferSet */ public get normal(): Buffer { return this._normal; From 559b6950b2ba4318ca44948350779e5f364a5f58 Mon Sep 17 00:00:00 2001 From: greenmashimaro Date: Tue, 23 Aug 2022 15:09:52 +0800 Subject: [PATCH 2/4] remove unnecessary eslint comments --- src/browser/LocalizableStrings.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/browser/LocalizableStrings.ts b/src/browser/LocalizableStrings.ts index c0a904cb..e34eaa48 100644 --- a/src/browser/LocalizableStrings.ts +++ b/src/browser/LocalizableStrings.ts @@ -3,8 +3,5 @@ * @license MIT */ -// eslint-disable-next-line prefer-const -export let promptLabel = 'Terminal input'; - -// eslint-disable-next-line prefer-const -export let tooMuchOutput = 'Too much output to announce, navigate to rows manually to read'; +export const promptLabel = 'Terminal input'; +export const tooMuchOutput = 'Too much output to announce, navigate to rows manually to read'; From ac81d3f72dd6a57e169dbf57b2942a7d1f87eadf Mon Sep 17 00:00:00 2001 From: greenmashimaro Date: Wed, 24 Aug 2022 22:41:45 +0800 Subject: [PATCH 3/4] feat: restore LocalizableStrings.ts const export --- src/browser/LocalizableStrings.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/browser/LocalizableStrings.ts b/src/browser/LocalizableStrings.ts index e34eaa48..fcf677c0 100644 --- a/src/browser/LocalizableStrings.ts +++ b/src/browser/LocalizableStrings.ts @@ -3,5 +3,12 @@ * @license MIT */ -export const promptLabel = 'Terminal input'; -export const tooMuchOutput = 'Too much output to announce, navigate to rows manually to read'; +/* + * note: intentional design, it's exposed to embedders of xterm.js + * so they can change the strings to localize xterm.js. #4055 + */ +// eslint-disable-next-line prefer-const +export let promptLabel = 'Terminal input'; + +// eslint-disable-next-line prefer-const +export let tooMuchOutput = 'Too much output to announce, navigate to rows manually to read'; From 86ba6cd2882fb0dfff2ac151b6f75f0a2bac76d5 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed, 24 Aug 2022 08:55:11 -0700 Subject: [PATCH 4/4] Tweak comment --- src/browser/LocalizableStrings.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/browser/LocalizableStrings.ts b/src/browser/LocalizableStrings.ts index fcf677c0..d8bcc2c6 100644 --- a/src/browser/LocalizableStrings.ts +++ b/src/browser/LocalizableStrings.ts @@ -3,10 +3,8 @@ * @license MIT */ -/* - * note: intentional design, it's exposed to embedders of xterm.js - * so they can change the strings to localize xterm.js. #4055 - */ +// This file contains strings that get exported in the API so they can be localized + // eslint-disable-next-line prefer-const export let promptLabel = 'Terminal input';