From b3d36478ca52763cbcff24f457001894b9be2841 Mon Sep 17 00:00:00 2001 From: RyotaK <49341894+Ry0taK@users.noreply.github.com> Date: Fri, 16 Dec 2022 17:01:00 +0000 Subject: [PATCH] Properly handle errors from URL constructor --- src/browser/OscLinkProvider.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/browser/OscLinkProvider.ts b/src/browser/OscLinkProvider.ts index 1b6ee483..648ffa44 100644 --- a/src/browser/OscLinkProvider.ts +++ b/src/browser/OscLinkProvider.ts @@ -69,8 +69,13 @@ export class OscLinkProvider implements ILinkProvider { let ignoreLink = false; if (!linkHandler?.allowNonHttpProtocols) { - const parsed = new URL(text); - if (!['http:', 'https:'].includes(parsed.protocol)) { + try { + const parsed = new URL(text); + if (!['http:', 'https:'].includes(parsed.protocol)) { + ignoreLink = true; + } + } catch (e) { + // Ignore invalid URLs to prevent unexpected behaviors ignoreLink = true; } }