From a9a6920b1303abb824abc9ae223ddc80221f19ef Mon Sep 17 00:00:00 2001 From: meganrogge Date: Tue, 15 Mar 2022 17:08:01 -0400 Subject: [PATCH] more cleanup --- src/browser/Decorations/BufferDecorationRenderer.ts | 1 + typings/xterm.d.ts | 7 ++----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/browser/Decorations/BufferDecorationRenderer.ts b/src/browser/Decorations/BufferDecorationRenderer.ts index 116c09a5..7cc2ee83 100644 --- a/src/browser/Decorations/BufferDecorationRenderer.ts +++ b/src/browser/Decorations/BufferDecorationRenderer.ts @@ -109,5 +109,6 @@ export class BufferDecorationRenderer extends Disposable { private _removeDecoration(decoration: IInternalDecoration): void { this._decorationElements.get(decoration)?.remove(); this._decorationElements.delete(decoration); + decoration.dispose(); } } diff --git a/typings/xterm.d.ts b/typings/xterm.d.ts index a86d80c8..940e3a48 100644 --- a/typings/xterm.d.ts +++ b/typings/xterm.d.ts @@ -439,11 +439,8 @@ declare module 'xterm' { element: HTMLElement | undefined; } - /** - * Options provided when registering a decoration - * containing a @param marker, @param anchor, - * @param x offset from the anchor, @param width in cells - * and @param height in cells. + /* + * Options that define the presentation of the decoration. */ export interface IDecorationOptions { /**