From 52694628175bfe427de163536d750f4a679cfce4 Mon Sep 17 00:00:00 2001 From: Anthony Kim Date: Fri, 17 Oct 2025 10:12:10 -0700 Subject: [PATCH 1/3] Only log character codes for verbose/trace --- src/common/services/CoreService.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/common/services/CoreService.ts b/src/common/services/CoreService.ts index 5bee6356..b42912aa 100644 --- a/src/common/services/CoreService.ts +++ b/src/common/services/CoreService.ts @@ -75,7 +75,8 @@ export class CoreService extends Disposable implements ICoreService { } // Fire onData API - this._logService.debug(`sending data "${data}"`, () => data.split('').map(e => e.charCodeAt(0))); + this._logService.debug(`sending data "${data}"`); + this._logService.trace(`sending data "${data}", and their character codes:`, () => data.split('').map(e => e.charCodeAt(0))); this._onData.fire(data); } @@ -83,7 +84,8 @@ export class CoreService extends Disposable implements ICoreService { if (this._optionsService.rawOptions.disableStdin) { return; } - this._logService.debug(`sending binary "${data}"`, () => data.split('').map(e => e.charCodeAt(0))); + this._logService.debug(`sending binary "${data}"`); + this._logService.trace(`sending binary "${data}", and their character codes:`, () => data.split('').map(e => e.charCodeAt(0))); this._onBinary.fire(data); } } From f87e5749712d8aacc6c61753e9852b31794e33f6 Mon Sep 17 00:00:00 2001 From: Anthony Kim <62267334+anthonykim1@users.noreply.github.com> Date: Fri, 17 Oct 2025 11:23:24 -0700 Subject: [PATCH 2/3] Update src/common/services/CoreService.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> --- src/common/services/CoreService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/services/CoreService.ts b/src/common/services/CoreService.ts index b42912aa..4d990bc8 100644 --- a/src/common/services/CoreService.ts +++ b/src/common/services/CoreService.ts @@ -85,7 +85,7 @@ export class CoreService extends Disposable implements ICoreService { return; } this._logService.debug(`sending binary "${data}"`); - this._logService.trace(`sending binary "${data}", and their character codes:`, () => data.split('').map(e => e.charCodeAt(0))); + this._logService.trace(`sending binary (codes)`, () => data.split('').map(e => e.charCodeAt(0))); this._onBinary.fire(data); } } From 67cf25989a08d7d6b74f96f4eb98765c920c714c Mon Sep 17 00:00:00 2001 From: Anthony Kim Date: Fri, 17 Oct 2025 11:26:34 -0700 Subject: [PATCH 3/3] only send codes, not the data when in trace --- src/common/services/CoreService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/services/CoreService.ts b/src/common/services/CoreService.ts index 4d990bc8..5d3eccb8 100644 --- a/src/common/services/CoreService.ts +++ b/src/common/services/CoreService.ts @@ -76,7 +76,7 @@ export class CoreService extends Disposable implements ICoreService { // Fire onData API this._logService.debug(`sending data "${data}"`); - this._logService.trace(`sending data "${data}", and their character codes:`, () => data.split('').map(e => e.charCodeAt(0))); + this._logService.trace(`sending data (codes)`, () => data.split('').map(e => e.charCodeAt(0))); this._onData.fire(data); }