From a5534152162ee9b7dcff08972dd0944c1071beb2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Breitbart?= Date: Sun, 26 Aug 2018 14:35:28 +0200 Subject: [PATCH] remove blankLine from Terminal --- src/Terminal.ts | 12 ------------ src/Types.ts | 2 -- src/utils/TestUtils.test.ts | 6 ------ 3 files changed, 20 deletions(-) diff --git a/src/Terminal.ts b/src/Terminal.ts index 28dced6c..457de0fc 100644 --- a/src/Terminal.ts +++ b/src/Terminal.ts @@ -1771,18 +1771,6 @@ export class Terminal extends EventEmitter implements ITerminal, IDisposable, II this.eraseRight(0, y); } - /** - * Return the data array of a blank line - * @param cur First bunch of data for each "blank" character. - * @param isWrapped Whether the new line is wrapped from the previous line. - * @param cols The number of columns in the terminal, if this is not - * set, the terminal's current column count would be used. - */ - // FIXME: can this be removed after transition to TerminalLine.blankLine? - public blankLine(cur?: boolean, isWrapped?: boolean, cols?: number): TerminalLine { - return TerminalLine.blankLine(cols || this.cols, cur ? this.eraseAttr() : DEFAULT_ATTR, isWrapped); - } - /** * If cur return the back color xterm feature attribute. Else return default attribute. * @param cur diff --git a/src/Types.ts b/src/Types.ts index 92fe9ed2..ecec9a95 100644 --- a/src/Types.ts +++ b/src/Types.ts @@ -75,7 +75,6 @@ export interface IInputHandlingTerminal extends IEventEmitter { eraseRight(x: number, y: number): void; eraseLine(y: number): void; eraseLeft(x: number, y: number): void; - blankLine(cur?: boolean, isWrapped?: boolean): TerminalLine; is(term: string): boolean; setgCharset(g: number, charset: ICharset): void; resize(x: number, y: number): void; @@ -235,7 +234,6 @@ export interface ITerminal extends PublicTerminal, IElementAccessor, IBufferAcce cancel(ev: Event, force?: boolean): boolean | void; log(text: string): void; showCursor(): void; - blankLine(cur?: boolean, isWrapped?: boolean, cols?: number): TerminalLine; } export interface IBufferAccessor { diff --git a/src/utils/TestUtils.test.ts b/src/utils/TestUtils.test.ts index 2e60be9e..a279b48b 100644 --- a/src/utils/TestUtils.test.ts +++ b/src/utils/TestUtils.test.ts @@ -146,9 +146,6 @@ export class MockTerminal implements ITerminal { refresh(start: number, end: number): void { throw new Error('Method not implemented.'); } - blankLine(cur?: boolean, isWrapped?: boolean, cols?: number): TerminalLine { - return TerminalLine.blankLine(this.cols, 0); - } registerCharacterJoiner(handler: CharacterJoinerHandler): number { return 0; } deregisterCharacterJoiner(joinerId: number): void { } } @@ -224,9 +221,6 @@ export class MockInputHandlingTerminal implements IInputHandlingTerminal { eraseLeft(x: number, y: number): void { throw new Error('Method not implemented.'); } - blankLine(cur?: boolean, isWrapped?: boolean): TerminalLine { - throw new Error('Method not implemented.'); - } prevStop(x?: number): number { throw new Error('Method not implemented.'); }