From a32776e2af437af8f8172188539bb1dce3a800c3 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Tue, 15 Sep 2020 10:33:28 -0700 Subject: [PATCH] Move role=document to xterm element Feedback in microsoft/vscode#98918 said this could improve the UX on screen readers --- src/browser/AccessibilityManager.ts | 1 - src/browser/Terminal.ts | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/AccessibilityManager.ts b/src/browser/AccessibilityManager.ts index c1d5e93f..0f25ea08 100644 --- a/src/browser/AccessibilityManager.ts +++ b/src/browser/AccessibilityManager.ts @@ -57,7 +57,6 @@ export class AccessibilityManager extends Disposable { this._rowContainer = document.createElement('div'); this._rowContainer.classList.add('xterm-accessibility-tree'); - this._rowContainer.setAttribute('role', 'document'); this._rowElements = []; for (let i = 0; i < this._terminal.rows; i++) { this._rowElements[i] = this._createAccessibilityTreeNode(); diff --git a/src/browser/Terminal.ts b/src/browser/Terminal.ts index 3f72bfef..f8b8b3e4 100644 --- a/src/browser/Terminal.ts +++ b/src/browser/Terminal.ts @@ -383,6 +383,7 @@ export class Terminal extends CoreTerminal implements ITerminal { this.element.classList.add('terminal'); this.element.classList.add('xterm'); this.element.setAttribute('tabindex', '0'); + this.element.setAttribute('role', 'document'); parent.appendChild(this.element); // Performance: Use a document fragment to build the terminal