From 9ebfb11ac8a7644adc7ed83ba0dde683142e4dc9 Mon Sep 17 00:00:00 2001 From: Ayman Bagabas Date: Fri, 19 Apr 2024 10:52:38 +0300 Subject: [PATCH] Fix tests --- addons/addon-clipboard/src/ClipboardAddon.ts | 4 ---- addons/addon-clipboard/test/ClipboardAddon.api.ts | 6 ++++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/addons/addon-clipboard/src/ClipboardAddon.ts b/addons/addon-clipboard/src/ClipboardAddon.ts index c7c9022f..b6dad8a5 100644 --- a/addons/addon-clipboard/src/ClipboardAddon.ts +++ b/addons/addon-clipboard/src/ClipboardAddon.ts @@ -30,10 +30,6 @@ export class ClipboardAddon implements ITerminalAddon { const pc = args[0]; const pd = args[1]; - if (pd.length === 0) { - return true; - } - switch (pc) { case ClipboardSelectionType.SYSTEM: case ClipboardSelectionType.PRIMARY: diff --git a/addons/addon-clipboard/test/ClipboardAddon.api.ts b/addons/addon-clipboard/test/ClipboardAddon.api.ts index 298ef0c3..4ef768e8 100644 --- a/addons/addon-clipboard/test/ClipboardAddon.api.ts +++ b/addons/addon-clipboard/test/ClipboardAddon.api.ts @@ -6,6 +6,7 @@ import { assert } from 'chai'; import { openTerminal, launchBrowser, writeSync, getBrowserType } from '../../../out-test/api/TestUtils'; import { Browser, BrowserContext, Page } from '@playwright/test'; +import { beforeEach } from 'mocha'; const APP = 'http://127.0.0.1:3001/test'; @@ -62,6 +63,7 @@ describe('ClipboardAddon', () => { assert.deepEqual(await page.evaluate(() => window.navigator.clipboard.readText()), ''); }); it('empty string', async () => { + await writeSync(page, `\x1b]52;c;${testDataEncoded}\x07`); await writeSync(page, `\x1b]52;c;\x07`); assert.deepEqual(await page.evaluate(() => window.navigator.clipboard.readText()), ''); }); @@ -75,12 +77,12 @@ describe('ClipboardAddon', () => { `); await page.evaluate(() => window.navigator.clipboard.writeText('hello world')); await writeSync(page, `\x1b]52;c;?\x07`); - assert.deepEqual(await page.evaluate(`window.data`), [`\x1b]52;c;${testDataEncoded}\x07`]); + assert.deepEqual(await page.evaluate('window.data'), [`\x1b]52;c;${testDataEncoded}\x07`]); }); it('clear clipboard', async () => { await writeSync(page, `\x1b]52;c;!\x07`); await writeSync(page, `\x1b]52;c;?\x07`); - assert.deepEqual(await page.evaluate(() => window.navigator.clipboard.readText()), '\x1b]52;c;\x07'); + assert.deepEqual(await page.evaluate(() => window.navigator.clipboard.readText()), ''); }); }); });