From 994861a6fad951cb25b608e4ad994cb89eaee301 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Breitbart?= Date: Tue, 1 Aug 2023 18:25:29 +0200 Subject: [PATCH] change repeat variable to const enum --- src/browser/services/CharSizeService.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/browser/services/CharSizeService.ts b/src/browser/services/CharSizeService.ts index a32eff16..8e2a7019 100644 --- a/src/browser/services/CharSizeService.ts +++ b/src/browser/services/CharSizeService.ts @@ -9,7 +9,9 @@ import { ICharSizeService } from 'browser/services/Services'; import { Disposable } from 'common/Lifecycle'; -const CHAR_REPEAT = 32; +const enum MeasureSettings { + REPEAT = 32 +} export class CharSizeService extends Disposable implements ICharSizeService { @@ -70,7 +72,7 @@ class DomMeasureStrategy implements IMeasureStrategy { ) { this._measureElement = this._document.createElement('span'); this._measureElement.classList.add('xterm-char-measure-element'); - this._measureElement.textContent = 'W'.repeat(CHAR_REPEAT); + this._measureElement.textContent = 'W'.repeat(MeasureSettings.REPEAT); this._measureElement.setAttribute('aria-hidden', 'true'); this._measureElement.style.whiteSpace = 'pre'; this._measureElement.style.fontKerning = 'none'; @@ -90,7 +92,7 @@ class DomMeasureStrategy implements IMeasureStrategy { // If values are 0 then the element is likely currently display:none, in which case we should // retain the previous value. if (geometry.width !== 0 && geometry.height !== 0) { - this._result.width = geometry.width / CHAR_REPEAT; + this._result.width = geometry.width / MeasureSettings.REPEAT; this._result.height = Math.ceil(geometry.height); }