From 855e9113983bb6bfa60e4316042f727beb32ce5c Mon Sep 17 00:00:00 2001
From: dennnnny <dcno017@gmail.com>
Date: Mon, 14 Aug 2023 09:49:18 +0800
Subject: [PATCH] Fix transparent foreground color

---
 src/browser/renderer/shared/TextureAtlas.ts | 2 +-
 src/browser/services/ThemeService.ts        | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/browser/renderer/shared/TextureAtlas.ts b/src/browser/renderer/shared/TextureAtlas.ts
index b73e7009..54171008 100644
--- a/src/browser/renderer/shared/TextureAtlas.ts
+++ b/src/browser/renderer/shared/TextureAtlas.ts
@@ -298,7 +298,7 @@ export class TextureAtlas implements ITextureAtlas {
       case Attributes.CM_DEFAULT:
       default:
         if (inverse) {
-          result = this._config.colors.foreground;
+          result = color.opaque(this._config.colors.foreground);
         } else {
           result = this._config.colors.background;
         }
diff --git a/src/browser/services/ThemeService.ts b/src/browser/services/ThemeService.ts
index 91a72f5e..2411ce85 100644
--- a/src/browser/services/ThemeService.ts
+++ b/src/browser/services/ThemeService.ts
@@ -122,8 +122,7 @@ export class ThemeService extends Disposable implements IThemeService {
    */
   private _setTheme(theme: ITheme = {}): void {
     const colors = this._colors;
-    colors.foreground = color.opaque(parseColor(theme.foreground, DEFAULT_FOREGROUND));
-    console.warn("xterm.js is not fully support foreground colors with transparent, so it will the foreground colors alpha channel to 255.")
+    colors.foreground = parseColor(theme.foreground, DEFAULT_FOREGROUND);
     colors.background = parseColor(theme.background, DEFAULT_BACKGROUND);
     colors.cursor = parseColor(theme.cursor, DEFAULT_CURSOR);
     colors.cursorAccent = parseColor(theme.cursorAccent, DEFAULT_CURSOR_ACCENT);