From 8478aa7a511154503e0b0a7bd3334119ca65a47d Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Sun, 5 Nov 2017 12:18:59 -0800 Subject: [PATCH] Fix selection on bottom right char when mouse goes outside viewport Part of #1029 --- src/SelectionManager.ts | 2 +- src/renderer/SelectionRenderLayer.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/SelectionManager.ts b/src/SelectionManager.ts index 5344e424..bf5144cb 100644 --- a/src/SelectionManager.ts +++ b/src/SelectionManager.ts @@ -495,7 +495,7 @@ export class SelectionManager extends EventEmitter implements ISelectionManager // If the cursor was above or below the viewport, make sure it's at the // start or end of the viewport respectively. if (this._dragScrollAmount > 0) { - this._model.selectionEnd[0] = this._terminal.cols - 1; + this._model.selectionEnd[0] = this._terminal.cols; } else if (this._dragScrollAmount < 0) { this._model.selectionEnd[0] = 0; } diff --git a/src/renderer/SelectionRenderLayer.ts b/src/renderer/SelectionRenderLayer.ts index 54eb7fc4..9740bb9a 100644 --- a/src/renderer/SelectionRenderLayer.ts +++ b/src/renderer/SelectionRenderLayer.ts @@ -77,7 +77,7 @@ export class SelectionRenderLayer extends BaseRenderLayer { // Draw final row if (viewportCappedStartRow !== viewportCappedEndRow) { - // Only draw viewportEndRow if it's not the same as viewporttartRow + // Only draw viewportEndRow if it's not the same as viewportStartRow const endCol = viewportEndRow === viewportCappedEndRow ? end[0] : terminal.cols; this.fillCells(0, viewportCappedEndRow, endCol, 1); }