From d92e63648269f3df7efb0635e677e3b4c1e51866 Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 15 Mar 2022 18:12:48 -0400 Subject: [PATCH 1/5] Update src/browser/Terminal.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> --- src/browser/Terminal.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/Terminal.ts b/src/browser/Terminal.ts index 98ed8b9a..d69e5d6f 100644 --- a/src/browser/Terminal.ts +++ b/src/browser/Terminal.ts @@ -583,7 +583,7 @@ export class Terminal extends CoreTerminal implements ITerminal { this.register(this.onScroll(() => this._mouseZoneManager!.clearAll())); this.linkifier.attachToDom(this.element, this._mouseZoneManager); this.linkifier2.attachToDom(this.screenElement, this._mouseService, this._renderService); - this._instantiationService.createInstance(BufferDecorationRenderer, this.screenElement); + this.register(this._instantiationService.createInstance(BufferDecorationRenderer, this.screenElement)); // This event listener must be registered aftre MouseZoneManager is created this.register(addDisposableDomListener(this.element, 'mousedown', (e: MouseEvent) => this._selectionService!.onMouseDown(e))); From 035a7f710ed59623572fd4983ab94492950da293 Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 15 Mar 2022 18:12:58 -0400 Subject: [PATCH 2/5] Update src/browser/Terminal.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> --- src/browser/Terminal.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/Terminal.ts b/src/browser/Terminal.ts index d69e5d6f..31ef1287 100644 --- a/src/browser/Terminal.ts +++ b/src/browser/Terminal.ts @@ -1016,7 +1016,7 @@ export class Terminal extends CoreTerminal implements ITerminal { } public registerDecoration(decorationOptions: IDecorationOptions): IDecoration | undefined { - return this._decorationService!.registerDecoration(decorationOptions); + return this._decorationService.registerDecoration(decorationOptions); } /** From 5777fbc60809fbc271f7f24424c58017a87ee4b5 Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 15 Mar 2022 18:13:10 -0400 Subject: [PATCH 3/5] Update src/browser/tsconfig.json Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> --- src/browser/tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/tsconfig.json b/src/browser/tsconfig.json index fc997477..212aeab8 100644 --- a/src/browser/tsconfig.json +++ b/src/browser/tsconfig.json @@ -18,7 +18,7 @@ "include": [ "./**/*", "../../typings/xterm.d.ts" -], + ], "references": [ { "path": "../common" } ] From 6f5008dba691b89943b468cc91321bb5d95d6af0 Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 15 Mar 2022 18:13:23 -0400 Subject: [PATCH 4/5] Update typings/xterm.d.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> --- typings/xterm.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/typings/xterm.d.ts b/typings/xterm.d.ts index 940e3a48..64ef2a08 100644 --- a/typings/xterm.d.ts +++ b/typings/xterm.d.ts @@ -268,7 +268,8 @@ declare module 'xterm' { windowOptions?: IWindowOptions; /** - * The width, in pixels, of the canvas for the overview ruler. + * The width, in pixels, of the canvas for the overview ruler. The overview + * ruler will be hidden when not set. */ overviewRulerWidth?: number; } From a4f830aa5d521cd8acfa8e9a920793806757f6fb Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Tue, 15 Mar 2022 18:13:36 -0400 Subject: [PATCH 5/5] Update typings/xterm.d.ts Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> --- typings/xterm.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/typings/xterm.d.ts b/typings/xterm.d.ts index 64ef2a08..24ba940e 100644 --- a/typings/xterm.d.ts +++ b/typings/xterm.d.ts @@ -400,7 +400,7 @@ declare module 'xterm' { } /** - * Represents a disposable with an + * Represents a disposable that tracks is disposed state. * @param onDispose event listener and * @param isDisposed property. */