From 7ad2a68052869bf3fd2d18e302a59bd4481e2791 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Breitbart?= Date: Thu, 14 Nov 2019 13:05:24 +0100 Subject: [PATCH] cleanup --- demo/client.ts | 2 +- src/common/TestUtils.test.ts | 1 - src/common/services/OptionsService.ts | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/demo/client.ts b/demo/client.ts index 42e4fe7d..7118ec2e 100644 --- a/demo/client.ts +++ b/demo/client.ts @@ -288,7 +288,7 @@ function initOptions(term: TerminalType): void { }); html += '
'; Object.keys(stringOptions).forEach(o => { - if (stringOptions[o] && typeof stringOptions[o] !== 'string') { + if (stringOptions[o]) { html += `
`; } else { html += `
`; diff --git a/src/common/TestUtils.test.ts b/src/common/TestUtils.test.ts index 42152fac..7d9c3aa6 100644 --- a/src/common/TestUtils.test.ts +++ b/src/common/TestUtils.test.ts @@ -75,7 +75,6 @@ export class MockLogService implements ILogService { export class MockOptionsService implements IOptionsService { serviceBrand: any; options: ITerminalOptions = clone(DEFAULT_OPTIONS); - windowOptions = 0; onOptionChange: IEvent = new EventEmitter().event; constructor(testOptions?: IPartialTerminalOptions) { if (testOptions) { diff --git a/src/common/services/OptionsService.ts b/src/common/services/OptionsService.ts index c05401d0..70a885fc 100644 --- a/src/common/services/OptionsService.ts +++ b/src/common/services/OptionsService.ts @@ -14,7 +14,6 @@ import { clone } from 'common/Clone'; // made, apart from the conversion to base64. export const DEFAULT_BELL_SOUND = 'data:audio/mp3;base64,SUQzBAAAAAAAI1RTU0UAAAAPAAADTGF2ZjU4LjMyLjEwNAAAAAAAAAAAAAAA//tQxAADB8AhSmxhIIEVCSiJrDCQBTcu3UrAIwUdkRgQbFAZC1CQEwTJ9mjRvBA4UOLD8nKVOWfh+UlK3z/177OXrfOdKl7pyn3Xf//WreyTRUoAWgBgkOAGbZHBgG1OF6zM82DWbZaUmMBptgQhGjsyYqc9ae9XFz280948NMBWInljyzsNRFLPWdnZGWrddDsjK1unuSrVN9jJsK8KuQtQCtMBjCEtImISdNKJOopIpBFpNSMbIHCSRpRR5iakjTiyzLhchUUBwCgyKiweBv/7UsQbg8isVNoMPMjAAAA0gAAABEVFGmgqK////9bP/6XCykxBTUUzLjEwMKqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq'; - // TODO: Freeze? export const DEFAULT_OPTIONS: ITerminalOptions = Object.freeze({ cols: 80,