From 714d4b1cd625e3e21e6fd2e10d145b378c80d7c9 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 10 May 2022 04:05:35 -0700 Subject: [PATCH] Fix fg color when there is a decoration override in canvas renderer --- src/browser/renderer/BaseRenderLayer.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/browser/renderer/BaseRenderLayer.ts b/src/browser/renderer/BaseRenderLayer.ts index b815c672..a4f1e233 100644 --- a/src/browser/renderer/BaseRenderLayer.ts +++ b/src/browser/renderer/BaseRenderLayer.ts @@ -479,13 +479,12 @@ export abstract class BaseRenderLayer implements IRenderLayer { let result = rgba.ensureContrastRatio(bgOverride ?? bgRgba, fgOverride ?? fgRgba, this._optionsService.rawOptions.minimumContrastRatio); if (!result) { - if (!bgOverride && !fgOverride) { + if (!fgOverride) { this._colors.contrastCache.setColor(cell.bg, cell.fg, null); return undefined; } // If it was an override and there was no contrast change, set as the result - // TODO: This is white when it should be green - result = fgRgba; + result = fgOverride; } const color: IColor = {