From 877e1e5eb30cdd8a9f4a9073a97b81c81a59dac4 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Mon, 21 Aug 2017 14:30:52 -0700 Subject: [PATCH] Prevent scrollback setOption < 0 Fixes #911 --- src/Terminal.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Terminal.ts b/src/Terminal.ts index a17cf94a..03babac5 100644 --- a/src/Terminal.ts +++ b/src/Terminal.ts @@ -454,6 +454,10 @@ export class Terminal extends EventEmitter implements ITerminal, IInputHandlingT } break; case 'scrollback': + if (value < 0) { + console.warn(`scrollback cannot be less than 0, value: ${value}`); + return; + } if (this.options[key] !== value) { const newBufferLength = this.rows + value; if (this.buffer.lines.length > newBufferLength) {