From 6ac9f59ef452f327f575cea86a9a0b4fd11714b3 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed, 17 Sep 2025 09:16:20 -0700 Subject: [PATCH] Fix tests --- addons/addon-search/src/SearchAddon.ts | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/addons/addon-search/src/SearchAddon.ts b/addons/addon-search/src/SearchAddon.ts index 3ea5d9ad..68449fa3 100644 --- a/addons/addon-search/src/SearchAddon.ts +++ b/addons/addon-search/src/SearchAddon.ts @@ -122,10 +122,7 @@ export class SearchAddon extends Disposable implements ITerminalAddon, ISearchAp this._highlightTimeout = setTimeout(() => { const term = this._cachedSearchTerm; this._cachedSearchTerm = undefined; - // Pass noScroll as true for internal incremental update - this._findPreviousAndSelect(term!, this._lastSearchOptions, { noScroll: true }); - this._fireResults(this._lastSearchOptions); - this._cachedSearchTerm = term; + this.findPrevious(term!, { ...this._lastSearchOptions, incremental: true }, { noScroll: true }); }, 200); } } @@ -152,7 +149,7 @@ export class SearchAddon extends Disposable implements ITerminalAddon, ISearchAp * @param searchOptions Search options. * @returns Whether a result was found. */ - public findNext(term: string, searchOptions?: ISearchOptions): boolean { + public findNext(term: string, searchOptions?: ISearchOptions, internalSearchOptions?: IInternalSearchOptions): boolean { if (!this._terminal) { throw new Error('Cannot use addon until it has been loaded'); } @@ -164,7 +161,7 @@ export class SearchAddon extends Disposable implements ITerminalAddon, ISearchAp } } - const found = this._findNextAndSelect(term, searchOptions); + const found = this._findNextAndSelect(term, searchOptions, internalSearchOptions); this._fireResults(searchOptions); this._cachedSearchTerm = term; @@ -326,7 +323,7 @@ export class SearchAddon extends Disposable implements ITerminalAddon, ISearchAp * @param searchOptions Search options. * @returns Whether a result was found. */ - public findPrevious(term: string, searchOptions?: ISearchOptions): boolean { + public findPrevious(term: string, searchOptions?: ISearchOptions, internalSearchOptions?: IInternalSearchOptions): boolean { if (!this._terminal) { throw new Error('Cannot use addon until it has been loaded'); } @@ -338,7 +335,7 @@ export class SearchAddon extends Disposable implements ITerminalAddon, ISearchAp } } - const found = this._findPreviousAndSelect(term, searchOptions); + const found = this._findPreviousAndSelect(term, searchOptions, internalSearchOptions); this._fireResults(searchOptions); this._cachedSearchTerm = term;